Seeking for sponsorship for linuxptp (PTP/IEEE1588 implementation)

[Tino Mettler]

On Wed, 2015-02-18 at 22:46 +0100, "IOhannes m zmölnig (Debian/GNU)"
wrote:

> me too (and I am personally interested in ptp packages).
> however, i would welcome it if the package would be team-maintained
> under the pkg-multimedia umbrella.

Hi,

I prepared a new repository. Feel free to change the maintainer field
for the team maintainership.

> anyhow, i'm currently doing a quick review of the package.
> some notes:
> 
> - i very much prefer to build the package using git(-buildpackage) to
> just buliding packages from mentors.d.n, as this is my proven toolchain
> to build in a chroot environment.

You can fetch the new repository here:

$ gbp clone http://tikei.de/git/linuxptp-debian.git

The master branch is the same as the debian/sid branch, which I created
for gbp pq.

> - as this package has never been in debian before, you can trim the
> debian/changelog to a bare minimum (that is: a single section for
> "1.5-1" [sic!])

Done.

> - there's a typo in README.Debian: "I also uses eth0" should probably
> read "It also uses eth0".

Done.

> it also might make a bit more sense to use "eth1" in the example (as the
> example you give does changes the behaviour to the original one :-))

The idea of the example was to put in the default values so the user can
change them to the desired values.

> - debian/rules
> there seems to be some cruft at the beginning of the file.
> e.g. why don't you just use `dpkg-parsechangelog -S Source` to get the
> srcpackage name?
> also you go through some hoops to parse the upstream-version from the
> debian/changelog, but then you hardcode UPSTREAMTAG to "upstream/1.5".
> most likely you can delete lines 3..8

Done.

> - configuration files:
> any reasons you don't put all configuration files into /etc/ptp4l/ ?
> this might allow you to replace the override_dh_auto_install cruft by a
> simple debian/install file (but this might rename the /etc/ptp4l.conf to
> /etc/ptp4l/default.conf)

Now all configuration files are installed in /etc/linuxptp/. The name of
ptp4l.conf is kept by using dh-exec in debian/install.

Regards,
Tino