Bug#804127: mp4v2-utils: mp4tags -picture option corrupts album artist

[Matteo F. Vescovi]

Hi!

On Thu, Nov 5, 2015 at 8:55 AM, Leigh Dyer <leigh at bandcamp.com> wrote:
> Due to a misplaced "break;" statement, when you use the -picture flag to
> mp4tags to specify the path to a cover art file, it also sets the album artist
> field (eg: as if using the -albumartist flag) to the path of the file given to
> the -picture flag.
>
> This bug has actually been previously reported:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=709127
>
> but the applied fix was wrong; rather than applying the supplied patch as-is,
> the "break" was put inside the "else" clause just above, so the bug persists
> in any case where the cover art is successfully set (and that "else" clause
> is not triggered).


Gosh, you're absolutely right! :-)
I don't know what I was thinking about 2 years ago, when applied
(badly) the patch provided.
Gonna fix it later today, I hope.

Cheers.

mfv