Bug#805169: cmus-plugin-ffmpeg: not linked with libavresample

[Andreas Cadhalpun]

Package: cmus-plugin-ffmpeg
Version: 2.5.0-7+b2
Tags: sid stretch patch
Severity: grave
Justification: makes the package unusable

Dear Maintainer,

the libav10.patch makes use of libavresample, but doesn't make sure
the plugin is actually linked with that library.

Thus cmus can't dlopen this plugin:
$ cmus --plugins | grep -A 3 ffmpeg
There is no output, while there should be:
$ cmus --plugins | grep -A 3 ffmpeg
  ffmpeg:
    Priority: 30
    File Types: ac3 aif aifc aiff ape au mka shn tta wma aac fla flac m4a m4b mp+ mp2 mp3 mp4 mpc mpp ogg wav wv
    MIME Types:

It used to work, because Libav's libavcodec links with libavresample,
but FFmpeg's libavcodec doesn't.

The following patch fixes this bug:
---8<---
--- cmus-2.5.0.orig/configure
+++ cmus-2.5.0/configure
@@ -347,7 +347,7 @@ check_aac()
 check_ffmpeg()
 {
 	HAVE_FFMPEG_AVCODEC_H=y
-	pkg_config FFMPEG "libavformat" || return $?
+	pkg_config FFMPEG "libavformat libavresample" || return $?
 	if check_header "libavcodec/avcodec.h" $FFMPEG_CFLAGS
 	then
 		HAVE_FFMPEG_AVCODEC_H=n
--->8---

However, it might be better to just import the new upstream version,
which uses libswresample instead of libavresample.

Best regards,
Andreas


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.3.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages cmus-plugin-ffmpeg depends on:
ii  libavformat-ffmpeg56  7:2.8.1-1+b1
ii  libc6                 2.19-22

cmus-plugin-ffmpeg recommends no packages.

Versions of packages cmus-plugin-ffmpeg suggests:
ii  cmus  2.5.0-7+b2

-- no debconf information