Bug#765578: vlc: FTBFS on Hurd

Samuel Thibault sthibault at debian.org
Sun Apr 24 10:22:39 UTC 2016


Control: tags -1 - wontfix
Control: tags -1 + patch

Hello,

We still can't the whole KDE world on hurd-i386 because of vlc not
building, while the remaining proposed patches should really not pose
problem (the controversial part was fixed in glibc). FTR, here are again
the proposed patches:

- hurd_path_max.patch: fixes an occurrence of PATH_MAX the exactly same
  way as it is arealdy done in src/posix/filesystem.c

- hurd_zsh_completion.patch: just tell zsh_completion that the library
  suffix is .so on GNU/Hurd too.

I don't see anything that can be controversial here, could you *please*
apply them, so we can move on?

Samuel
-------------- next part --------------
Description: Replace PATH_MAX, unsupported on Hurd, with fixed size as in
 src/posix/filesystem.c
Author: Gabriele Giacone <1o5g4r8o at gmail.com>
--- a/modules/gui/skins2/src/theme_loader.cpp
+++ b/modules/gui/skins2/src/theme_loader.cpp
@@ -509,7 +509,10 @@ int tar_extract_all( TAR *t, char *prefi
     union tar_buffer buffer;
     int   len, err, getheader = 1, remaining = 0;
     FILE  *outfile = NULL;
-    char  fname[BLOCKSIZE + PATH_MAX];
+
+    long path_max = pathconf (".", _PC_PATH_MAX);
+    size_t maxsize = (path_max == -1 || path_max > 4096) ? 4096 : path_max;
+    char  fname[BLOCKSIZE + maxsize];
 
     while( 1 )
     {
-------------- next part --------------
--- a/extras/analyser/zsh_completion.sh.orig	2015-08-28 21:34:50.000000000 +0000
+++ b/extras/analyser/zsh_completion.sh	2015-08-28 21:35:10.000000000 +0000
@@ -13,7 +13,7 @@
     *cygwin*|*mingw*)
         SUFFIX=dll
     ;;
-    *linux*|*bsd*)
+    *linux*|*bsd*|*gnu*)
         SUFFIX=so
     ;;
     *)


More information about the pkg-multimedia-maintainers mailing list