Bug#822727: NDEBUG not defined during build

[Rob Sykes]

Package: libsoxr0
Version: 0.1.2-1
Severity: normal
Tags: patch

This appears to be a consequence of the fix for Debian Bug #711515.

Apart from the overhead that this introduces through the assert macro,
not defining NDEBUG causes the library to write debug info to stderr,
which can appear, for example, when running a command-line application
using the library (e.g. ffmpeg).

One possible fix is per the following patch to the upstream source:


diff --git a/CMakeLists.txt b/CMakeLists.txt
index 406e826..c89ad0b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -32,6 +32,8 @@ include (CMakeDependentOption)
 
 if (NOT CMAKE_BUILD_TYPE)
   set (CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build, options are: None Debug Release RelWithDebInfo MinSizeRel." FORCE)
+elseif (CMAKE_BUILD_TYPE STREQUAL "None")
+  add_definitions(-DNDEBUG)
 endif ()
 
 option (BUILD_TESTS "Build sanity-tests."  ON)


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-21-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libsoxr0 depends on:
ii  libc6     2.23-0ubuntu3
ii  libgomp1  5.3.1-14ubuntu2

libsoxr0 recommends no packages.

libsoxr0 suggests no packages.

-- no debconf information