Bug#833841: kodi: Checks fail at TestSystemInfo.GetOsVersion when building package

[Simon Frei]

Source: kodi
Version: 16.1+dfsg1-1
Severity: normal

I tried to create a binary package from the current git source with an additional patch included with dpkg-buildpackage and it fails at target "check" (also without my additional patch). The check fails as g_sysinfo.GetOsVersion returns "testing" while the check assumes it will be a number/dots kind of version. This check is kind of useless, as the tested function g_sysinfo.GetOsVersion is never used in the code.
I report this here as I actually encountered it as a debian packaging issue and somehow the maintainer must have circumvented this, but I guess the resolution should happen upstream? An easy but dirty fix is of course to just outcomment this test.
Relevant command line output:

  [ RUN      ] TestSystemInfo.Print_System_Info
  [...]
  'GetOsVersion()': "testing"
  [...]
  [ RUN      ] TestSystemInfo.GetOsVersion
  TestSystemInfo.cpp:134: Failure
  Value of: g_sysinfo.GetOsVersion().find_first_of("0123456789")
    Actual: 18446744073709551615
  Expected: 0
  'GetOsVersion()' must not return version not starting from digit
  TestSystemInfo.cpp:135: Failure
  Value of: g_sysinfo.GetOsVersion().find_first_not_of("0123456789.")
    Actual: 0
  Expected: std::string::npos
  Which is: 18446744073709551615
  'GetOsVersion()' must not return version with not only digits and dots
  [  FAILED  ] TestSystemInfo.GetOsVersion (0 ms)

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (2, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)