Packaging Advanced Gtk+ Sequencer v0.7.56

[Joël Krähemann]

Hi

On Mon, Aug 29, 2016 at 11:11 PM, IOhannes m zmölnig (Debian/GNU)
<umlaeute at debian.org> wrote:
> On 08/29/2016 08:39 PM, Joël Krähemann wrote:
>> On Mon, Aug 29, 2016 at 7:41 PM, IOhannes m zmölnig (Debian/GNU)
>> <umlaeute at debian.org> wrote:
>>>
>>>
>>> apart from that:
>>> - the libags-1.0.pc seems weird: there are duplicate entries, and it
>>> adds /usr/local/ paths to both include and library search paths. i'm
>>> pretty sure that this is wrong.
>>> it also adds include-paths and libraries for quite a number of graphic
>>> libraries (from cairo to png) - i wonder whether they are really needed
>>> to use libags.
>>>
>> The /usr/local paths doesn't happen to me it is probably a
>> dh_auto_configure issue with your package builder:
>>
>> prefix=/usr
>> exec_prefix=${prefix}
>> libdir=${prefix}/lib/x86_64-linux-gnu
>> includedir=${prefix}/include
>
> ah indeed, the problem was on my side (not the build, which was fine;
> but one of the pkgconfig-dependencies got picked up from /usr/local
> during runtime).
>
> apart from that, i still think that there are way too many dependencies.
> e.g. why is there an include <pango/pango.h> in X/machine/ags_ffplayer.h?
> none of the pango-symbols are part of the public API of gsequencer-dev,
> so there shouldn't be any need to have libpango-dev installed if i just
> want to link against libgsequencer
>
>>
>> And yes, libags-1.0.pc should rather be libgsequencer-0.7.pc
>
> if so, then please fix it.
>

There are now .pc files for each package.

>>
>>> - is there a specific reason to have the version encoded in library
>>> names rather than the sonames (e.g. libags-1.0.so.0.0.0 rather than
>>> libags.so.0.1.0)?
>>>
>> I just read this article:
>>
>> https://autotools.io/libtool/version.html
>
> i'm not sure i understand what you are trying to say here.
> did you read simply this article, and then decided to use
> libtags-1.0.so.0.0.0? or did you read this article recently, after i
> complained?
>

No I read it prior and found it again.

> i find a very good introduction to semantic versioning is http://semver.org/
>
>>
>> I fix this upstream so I'll provide a new package gsequencer-0.7.58.tar.gz
>
> thanks.
>
> gfmdsar
> IOhannes
>
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

all I get for now is:

W: libags-doc: package-contains-devhelp-file-without-symlink
usr/share/doc/libags-doc/api/libags.devhelp2
W: gsequencer: package-name-doesnt-match-sonames libags0 libags-audio0
libags-gui0 libags-server0 libags-thread0 libgsequencer0
E: gsequencer: binary-or-shlib-defines-rpath usr/bin/gsequencer
/home/joelkraehemann/debian-repos/gsequencer/.libs
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libags_thread.so.0.0.1
usr/lib/x86_64-linux-gnu/libags_thread.so
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libgsequencer.so.0.0.1
usr/lib/x86_64-linux-gnu/libgsequencer.so
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libags_gui.so.0.0.1
usr/lib/x86_64-linux-gnu/libags_gui.so
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libags_server.so.0.0.1
usr/lib/x86_64-linux-gnu/libags_server.so
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libags.so.0.0.1
usr/lib/x86_64-linux-gnu/libags.so
W: gsequencer: non-dev-pkg-with-shlib-symlink
usr/lib/x86_64-linux-gnu/libags_audio.so.0.0.1
usr/lib/x86_64-linux-gnu/libags_audio.so
W: libags-gui-dev: wrong-section-according-to-package-name
libags-gui-dev => libdevel
W: libags-gui-doc: package-contains-devhelp-file-without-symlink
usr/share/doc/libags-gui-doc/api/libags_gui.devhelp2
W: libgsequencer-doc: package-contains-devhelp-file-without-symlink
usr/share/doc/libgsequencer-doc/api/libgsequencer.devhelp2
W: libags-audio-doc: package-contains-devhelp-file-without-symlink
usr/share/doc/libags-audio-doc/api/libags_audio.devhelp2
W: libgsequencer-dev: wrong-section-according-to-package-name
libgsequencer-dev => libdevel
W: libags-dev: wrong-section-according-to-package-name libags-dev => libdevel
W: libags-audio-dev: wrong-section-according-to-package-name
libags-audio-dev => libdevel

I don't set rpath in upstream Makefile.am so it's a guess it comes of
the build-system. Further I do symlinks in /usr/share/gtk-doc/html and
/usr/share/devhelp/books doesn't exist on my system, so I'm unsure.

I especially need help with soname and section because I don't know if
it should be like that.

Bests,
Joël