Bug#847988: pd-libdir: does not respect current loader path

[IOhannes m zmoelnig]

Package: pd-libdir
Version: 1.9-3
Severity: important

Dear Maintainer,

pd-libdir does not integrate nicely with Pd anymore.

Prior to Pd-0.47, Pd would iterate over all the loaders, and each loader would
then search all the paths as it deemed appropriate.
However, since Pd-0.47, Pd iterates over all search paths and calls each loader on each
path.
This is implemented by a slight change in API semantics when calling the
loaders: the loader callback got a 3rd argument 'path'; if non-NULL the loader
is supposed to only search this path;
if no loader has been succeeded, all of the loaders are again called, this time
with a path=NULL (so they know that this is the final round and they can search
additional resources; the loader should NOT iterate over the pd-searchpath
again).

anyhow, pd-libdir currently ignores the 'path' argument, thus breaking the new
loader  call semantics.
also, if pd-libdir cannot find a given library, it will keep searching for the
library in all search paths for each search path, thus doing N*(N+1) checks
(while 1 would have been enough)

please fix the loader, so it respects the 'path' argument.

PS: using important since pd-libdir is a core pd-package, thus effecting many
systems.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.8.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages pd-libdir depends on:
ii  libc6               2.24-8
ii  puredata-core [pd]  0.47.1-3

Versions of packages pd-libdir recommends:
ii  puredata-import [pd-import]  1.3-3

pd-libdir suggests no packages.

-- no debconf information