Request for review & inclusion: sonic-pi (see #796550)

Mon Feb 8 19:07:10 UTC 2016

Hi Hanno,

thank you for packing Sonic Pi

On 2016-02-08 17:48:32, Hanno Zulla wrote:
> Hi Debian-Multimedia,
> Hi Petter,
> 
> I *hope* the package is now in pretty good shape and request a review.
> 
> Please have a look at
> 
> <https://github.com/deb-pkg-sonic-pi/pkg-sonic-pi>
> 
> and let me know what you think. The contents of the debian/ folder is
> fairly well documented.

Please run tests in override_dh_auto_test. Also your package does not honor
notests in DH_OPTIONS.

Why has sonic-pi-server a hard-coded dependency on libffi6? Why does it depend
on jackd2 and not jackd as other packages using jackd do?

> The remaining lintian errors are:
> 
> > W: sonic-pi: wrong-name-for-upstream-changelog
> > usr/share/doc/sonic-pi/CHANGELOG.md.gz
> 
> Yes, but it's a markdown file, so what else should be done?

Not sure which lintian version you are using, but a current lintian reports:

W: sonic-pi: duplicate-changelog-files usr/share/doc/sonic-pi/CHANGELOG.md.gz usr/share/doc/sonic-pi/changelog.gz

dh_installchangelogs already does the right thing, so remove the extra copy
(CHANGELOG.md.gz).

> > W: sonic-pi: binary-without-manpage usr/bin/sonic-pi
> 
> Ok, does this binary really require a man page? It's a GUI application,
> not to be used from the command line.

The manpage will be quiet simple in this case.

lintian also reports:

I: sonic-pi source: wildcard-matches-nothing-in-dep5-copyright etc/wavetables/* (paragraph at line 489)
I: sonic-pi source: wildcard-matches-nothing-in-dep5-copyright .app/server/vendor/ruby-beautify/* (paragraph at line 494)
I: sonic-pi source: unused-file-paragraph-in-dep5-copyright paragraph at line 489
I: sonic-pi source: unused-file-paragraph-in-dep5-copyright paragraph at line 494

That ought to be fixed.

I: sonic-pi source: debian-watch-file-is-missing

Since you are tracking tags here, a watch file and Files-Excluded in
debian/copyright seem much easier than a get-orig-source target.

W: sonic-pi-dbgsym: debug-file-with-no-debug-symbols usr/lib/debug/.build-id/b9/85036da5c4c691e6d83c3e6d567e90171061b6.debug
W: sonic-pi: hardening-no-relro usr/bin/sonic-pi

These warnings are an indicator that the build system does not honor *FLAGS. And
indeed, blhc reportS:

CXXFLAGS missing (-g -fstack-protector-strong -Wformat -Werror=format-security): g++ -c -m64 -pipe -Wall -Werror -Wextra -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CONCURRENT_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I/Users/sam/Downloads/tmp/QScintilla-gpl-2.9/Qt4Qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o moc_sonicpitheme.o moc_sonicpitheme.cpp
CPPFLAGS missing (-D_FORTIFY_SOURCE=2): g++ -c -m64 -pipe -Wall -Werror -Wextra -O2 -Wall -W -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CONCURRENT_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I/Users/sam/Downloads/tmp/QScintilla-gpl-2.9/Qt4Qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++-64 -o moc_sonicpitheme.o moc_sonicpitheme.cpp
LDFLAGS missing (-Wl,-z,relro): g++ -m64 -Wl,-O1 -o sonic-pi main.o mainwindow.o sonicpilexer.o sonicpiapis.o sonicpiscintilla.o oschandler.o sonicpilog.o sonicpiserver.o sonicpiudpserver.o sonicpitcpserver.o sonicpitheme.o qrc_SonicPi.o qrc_help_files.o qrc_info_files.o moc_mainwindow.o moc_sonicpilog.o moc_sonicpiscintilla.o moc_sonicpiserver.o moc_sonicpiudpserver.o moc_sonicpitcpserver.o moc_sonicpitheme.o   -L/usr/X11R6/lib64 -L/Users/sam/Downloads/tmp/QScintilla-gpl-2.9/Qt4Qt5 -lqt5scintilla2 -lQt5Widgets -lQt5Gui -lQt5Concurrent -lQt5Network -lQt5Core -lGL -lpthread 

I: sonic-pi-server: description-synopsis-might-not-be-phrased-properly
I: sonic-pi: description-synopsis-might-not-be-phrased-properly
I: sonic-pi-server-doc: description-synopsis-might-not-be-phrased-properly
I: sonic-pi-samples: description-synopsis-might-not-be-phrased-properly

These tags probably refers to extra dot at the end of the short description.
Please remove them. Also the detail that sonic-pi-server is implemented in Ruby
is misplaced in the short Description. That's something that can be documented
via debtags.

I: sonic-pi: spelling-error-in-binary usr/bin/sonic-pi nam name
I: sonic-pi: spelling-error-in-binary usr/bin/sonic-pi Programm Program
I: sonic-pi: spelling-error-in-binary usr/bin/sonic-pi informations information
I: sonic-pi: spelling-error-in-binary ... use --no-tag-display-limit to see all (or pipe to a file/program)

Would be nice to have these fixed, preferably upstream.

I: sonic-pi: desktop-entry-contains-encoding-key usr/share/applications/sonic-pi.desktop:2 Encoding
I: sonic-pi: desktop-entry-lacks-keywords-entry usr/share/applications/sonic-pi.desktop

Since the desktop file is coming from debian/, please fix these tags.

I: sonic-pi: possible-documentation-but-no-doc-base-registration
I: sonic-pi-server-doc: possible-documentation-but-no-doc-base-registration

Please add the doc-base registration.

I: sonic-pi-samples: extended-description-is-probably-too-short

The description could certainly be longer. You could follow the pattern other
packages use: explain in the first paragraph what Sonic Pi is and in the second
paragraph mentioned that this package contains audio samples.

Chertain
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160208/0e3d1b3b/attachment.sig>