Bug#814984: Supercollider: Add hardening flags to debian/rules in supercollider source package

Felipe Sateler fsateler at debian.org
Wed Feb 17 12:50:51 UTC 2016


On 17 February 2016 at 07:42, Hanno Zulla <abos at hanno.de> wrote:
> Source: supercollider
> Version: 1:3.6.6_repack-2-2
> Severity: minor
>
> Hi there,

Hi,

>
> sid's lintian complains about missing hardening in the supercollider
> build. This patch adds the needed flags.
>
> Please let me know
>
> a) if this patch is correct

I have not tested this, does this actually pass the right variables?
I'm wary of the interactions between the cdbs rules and including
dpkg's makefile snippet. Unfortunately , bug #712729 means the
built-int support in cdbs is currently broken :(


>
> b) if this is the proper format to submit it

This is OK, although given you are already in the team you could have
pushed a branch and asked for review/merge to the git repo directly
(or an ACK to do the merge yourself).

>
> c) if this is the proper channel to submit patches like this.

This is OK, as it also helps keeping track of patches.


-- 

Saludos,
Felipe Sateler



More information about the pkg-multimedia-maintainers mailing list