Bug#828955: giada: FTBFS with rtmidi 2.1.1

[Jaromír Mikeš]

2016-07-04 15:12 GMT+02:00 James Cowgill <jcowgill at debian.org>:
> On Mon, 2016-07-04 at 13:53 +0200, Jaromír Mikeš wrote:
>> 2016-06-29 11:58 GMT+02:00 Jaromír Mikeš <mira.mikes at seznam.cz>:
>> > Package: giada
>> > Version: 0.12.2~dfsg1-1
>> > Severity: important
>> > User: pkg-multimedia-maintainers at lists.alioth.debian.org
>> > Usertags: rtmidi 2.1.1
>> >
>> > Dear Maintainer,
>> >
>> > your package fails to build with the upcoming rtmidi2.1.1
>> >
>> > Location of header files changed from include to include/rtmidi so
>> > some easy patching will be needed.
>> > Otherwise it builds fine.

>> can someone help me to patch package giada so RtMidi.h and
>> rtmidi/RtMidi.h would both accepted by build?

Hi James, ;)

> I think the attached patch should work. PKG_CHECK_MODULES is the
> autoconf macro you want. This will cause RTMIDI_CFLAGS and RTMIDI_LIBS
> to be exported for use in Makefile.am.

Thank you!

> However, I think there's a bug in rtmidi. You patched the pkg-config
> file to remove @CPPFLAGS@, but some of the flags (the -D__* ones) are
> needed by the users of rtaudio.

I have done it as lintian complained about that. Should the patch be removed?
Other solution?

---

giada not build unfortunately :(

g++  -g -O2 -fPIE -fstack-protector-strong -Wformat
-Werror=format-security  -fPIE -pie -Wl,-z,relro -Wl,-z,now
-Wl,--as-needed -o giada src/giada-main.o src/core/giada-channel.o
src/core/giada-sampleChannel.o src/core/giada-midiChannel.o
src/core/giada-midiMapConf.o src/core/giada-conf.o
src/core/giada-kernelAudio.o src/core/giada-pluginHost.o
src/core/giada-mixerHandler.o src/core/giada-init.o
src/core/giada-plugin.o src/core/giada-wave.o src/core/giada-waveFx.o
src/core/giada-kernelMidi.o src/core/giada-graphics.o
src/core/giada-patch_DEPR_.o src/core/giada-patch.o
src/core/giada-recorder.o src/core/giada-mixer.o
src/core/giada-dataStorageIni.o src/core/giada-dataStorageJson.o
src/glue/giada-glue.o src/glue/giada-storage.o
src/glue/giada-channel.o src/gui/dialogs/giada-gd_keyGrabber.o
src/gui/dialogs/giada-gd_about.o src/gui/dialogs/giada-gd_mainWindow.o
src/gui/dialogs/giada-gd_beatsInput.o
src/gui/dialogs/giada-gd_warnings.o
src/gui/dialogs/giada-gd_bpmInput.o src/gui/dialogs/giada-gd_browser.o
src/gui/dialogs/giada-gd_config.o src/gui/dialogs/giada-gd_devInfo.o
src/gui/dialogs/giada-gd_pluginList.o
src/gui/dialogs/giada-gd_pluginWindow.o
src/gui/dialogs/giada-gd_editor.o
src/gui/dialogs/giada-gd_pluginWindowGUI.o
src/gui/dialogs/giada-gd_midiOutput.o
src/gui/dialogs/giada-gd_midiInput.o
src/gui/dialogs/giada-gd_actionEditor.o
src/gui/dialogs/giada-gd_pluginChooser.o
src/gui/elems/giada-ge_column.o src/gui/elems/giada-ge_sampleChannel.o
src/gui/elems/giada-ge_midiChannel.o
src/gui/elems/giada-ge_midiIoTools.o src/gui/elems/giada-ge_mixed.o
src/gui/elems/giada-ge_waveform.o src/gui/elems/giada-ge_browser.o
src/gui/elems/giada-ge_actionWidget.o
src/gui/elems/giada-ge_envelopeChannel.o
src/gui/elems/giada-ge_pianoRoll.o src/gui/elems/giada-ge_channel.o
src/gui/elems/giada-ge_muteChannel.o
src/gui/elems/giada-ge_actionChannel.o src/gui/elems/giada-ge_window.o
src/gui/elems/giada-ge_status.o src/gui/elems/giada-ge_keyboard.o
src/gui/elems/giada-ge_waveTools.o src/gui/elems/giada-ge_modeBox.o
src/gui/elems/giada-ge_controller.o
src/gui/elems/giada-ge_channelButton.o
src/gui/elems/giada-ge_pluginBrowser.o src/utils/giada-log.o
src/utils/giada-gui_utils.o src/utils/giada-utils.o
src/deps/rtaudio-mod/giada-RtAudio.o   -lsndfile -lfltk -lXext -lX11
-lXft -lXpm -lm -ljack -lasound -lpthread -ldl -lpulse-simple -lpulse
-lsamplerate -lrtmidi -lasound -ljansson -lfreetype -lpthread
src/core/giada-kernelAudio.o: In function `kernelAudio::jackGetHandle()':
/home/mira/PACKAGING/giada/src/core/kernelAudio.cpp:426: undefined
reference to `RtApi::__HACK__getJackClient()'
/home/mira/PACKAGING/giada/src/core/kernelAudio.cpp:426: undefined
reference to `RtApi::__HACK__getJackClient()'
/home/mira/PACKAGING/giada/src/core/kernelAudio.cpp:426: undefined
reference to `RtApi::__HACK__getJackClient()'
/home/mira/PACKAGING/giada/src/core/kernelAudio.cpp:426: undefined
reference to `RtApi::__HACK__getJackClient()'
collect2: error: ld returned 1 exit status
Makefile:1259: recipe for target 'giada' failed


regards

mira