Bug#831183: giada: FTBFS with GCC 6: src/core/recorder.cpp:654:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]

[Lucas Nussbaum]

Source: giada
Version: 0.12.2~dfsg1-2
Severity: serious
Tags: stretch sid
User: debian-qa at lists.debian.org
Usertags: qa-ftbfs-20160713 qa-ftbfs
Justification: FTBFS with GCC 6 on amd64

Hi,

During a rebuild of all packages in sid using the gcc-defaults package
available in experimental to make GCC default to version 6, your package failed
to build on amd64. For more information about GCC 6 and Stretch, see:
- https://wiki.debian.org/GCC6
- https://lists.debian.org/debian-devel-announce/2016/06/msg00007.html

Relevant part (hopefully):
> g++ -DPACKAGE_NAME=\"giada\" -DPACKAGE_TARNAME=\"giada\" -DPACKAGE_VERSION=\"0.12\" -DPACKAGE_STRING=\"giada\ 0.12\" -DPACKAGE_BUGREPORT=\"giadaloopmachine at gmail.com\" -DPACKAGE_URL=\"\" -DPACKAGE=\"giada\" -DVERSION=\"0.12\" -DHAVE_LIBPTHREAD=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -I.   -D__UNIX_JACK__ -D__LINUX_ALSA__ -Wdate-time -D_FORTIFY_SOURCE=2 -DBUILD_DATE='"2016/07/04"' -std=c++11 -Wall -Werror -Wno-error=vla  -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++11 -c -o src/core/giada-recorder.o `test -f 'src/core/recorder.cpp' || echo './'`src/core/recorder.cpp
> src/core/recorder.cpp: In function 'void recorder::stopOverdub(int)':
> src/core/recorder.cpp:654:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
>   if (!nullLoop)
>   ^~
> src/core/recorder.cpp:656:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
>    deleteActions(cmp.a2.chan, cmp.a1.frame, cmp.a2.frame, cmp.a2.type);
>    ^~~~~~~~~~~~~
> cc1plus: all warnings being treated as errors
> make[1]: *** [src/core/giada-recorder.o] Error 1

The full build log is available from:
   http://people.debian.org/~lucas/logs/2016/07/13/giada_0.12.2~dfsg1-2_unstable_gcc6.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.