[SCM] giada/master: Add patch to build with gcc6 (Closes: ##831183).

[Jaromír Mikeš]

2016-07-25 12:55 GMT+02:00 Fabian Greffrath <fabian at greffrath.com>:
>> this patch fixing build of giada package with gcc6, but now it is not
>> build with gcc5 with pbuilder :(
>> Help needed please.
>
> I can only guess since you are not providing any build logs, but there is
> one thing in your patch that made me wonder. You are writing floating
> point numbers in 'char buf[8];' buffers. Are you sure that they will fit?


Here is a build log with gcc5:

g++ -DPACKAGE_NAME=\"giada\" -DPACKAGE_TARNAME=\"giada\"
-DPACKAGE_VERSION=\"0.12\" -DPACKAGE_STRING=\"giada\ 0.12\"
-DPACKAGE_BUGREPORT=\"giadaloopmachine at gmail.com\" -DPACKAGE_URL=\"\"
-DPACKAGE=\"giada\" -DVERSION=\"0.12\" -DHAVE_LIBPTHREAD=1
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_UNISTD_H=1 -I.   -D__UNIX_JACK__ -D__LINUX_ALSA__ -Wdate-time
-D_FORTIFY_SOURCE=2 -DBUILD_DATE='"2016/07/24"' -std=c++11 -std=c++11
-Wall -Werror -Wno-error=vla  -g -O2 -fPIE -fstack-protector-strong
-Wformat -Werror=format-security -c -o src/glue/giada-glue.o `test -f
'src/glue/glue.cpp' || echo './'`src/glue/glue.cpp
src/glue/glue.cpp: In function 'void glue_setPanning(gdEditor*,
SampleChannel*, float)':
src/glue/glue.cpp:714:58: error: format '%f' expects argument of type
'double', but argument 3 has type 'int' [-Werror=format=]
   sprintf(buf, "%f L", abs((ch->panRight * 100.0f) - 100));
                                                          ^
src/glue/glue.cpp:727:57: error: format '%f' expects argument of type
'double', but argument 3 has type 'int' [-Werror=format=]
   sprintf(buf, "%f R", abs((ch->panLeft * 100.0f) - 100));
                                                         ^
cc1plus: all warnings being treated as errors
Makefile:1768: recipe for target 'src/glue/giada-glue.o' failed

When building with gcc6 error was opossite (without patch)
sth like:
format '%d' expects argument of type 'int', but argument 3 has type
'double' [-Werror=format=]

mira