rtmidi package review

[James Cowgill]

On Wed, 2016-06-22 at 16:29 +0200, Jaromír Mikeš wrote:
> 2016-06-22 14:49 GMT+02:00 James Cowgill <jcowgill at debian.org>:
> > On Tue, 2016-06-21 at 22:42 +0200, Jaromír Mikeš wrote:
> > > Hi,
> > > 
> > > can someone review rtmidi package please?
[...]
> > The build system clobbers CXXFLAGS. Line 81 of configure.ac seems
> > to be the culprit.
> 
> I've tried fix passing flags on this line in configure.ac file, but
> it still doesn't work :(

I think it works if you reenable the line which is commented out so
that $cxxflag is appended to CXXFLAGS instead of replacing it.
Something like this:

--- a/configure.ac
+++ b/configure.ac
@@ -77,8 +77,7 @@ fi
 CPPFLAGS="$CPPFLAGS $cppflag"
 
 # For debugging and optimization ... overwrite default because it has both -g and -O2
-#CXXFLAGS="$CXXFLAGS $cxxflag"
-CXXFLAGS="$cxxflag"
+CXXFLAGS="$CXXFLAGS $cxxflag"
 
 # Check compiler and use -Wall if gnu.
 if [test $GXX = "yes" ;] then

James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160622/aa3c1850/attachment-0001.sig>