Bug#824078: libdvd-pkg: fails to report "apt-get check" errors (and others) correctly

Dmitry Smirnov onlyjob at debian.org
Sun May 15 09:48:25 UTC 2016

Hi Cyril,

Thank you for your concerns and bug report.

On Thursday, 12 May 2016 12:44:30 AM AEST Cyril Brulebois wrote:
> Severity: important

I don't understand how not returning exit code qualifies for "important" 
severity... IMHO it is "minor" unless I'm missing what kind of breakage it 
may cause...

> But our wrapper specifically exited with '1' in that case, and it seemed
> strange that debian/b-i_libdvdcss.sh didn't catch that.
> [...]
> I would suggest storing the return value
> e.g. with "ret=$?", and using "exit $ret" so that this return value is
> propagated. If propagating this return value isn't deemed interesting,
> please at least "exit 1".

This is not just ugly code of mine but deliberate/intentional decision to 
override exit code. Trouble is that libdvd-pkg hooks into APT post-invoke 
handler and run commands that normally never run on that stage. Therefore 
there is a risk and potential to break APT operations and cause system-wide 

I feel uncomfortable about propagating exit status without good understanding 
of consequences and without serious testing (for which I have not time right 

 Dmitry Smirnov.


The greatest personal limitation is to be found not in the things you want
to do and can't, but in the things you've never considered doing.
        -- Richard Bandler
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160515/dc8e304d/attachment.sig>

More information about the pkg-multimedia-maintainers mailing list