Bug#843173: libfaad-dev: Implicit SBR detection via AudioSpecificConfig fails when char is signed

[Fabian Greffrath]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Stefan,

thanks for the bug report!

Did you mean to write "fails when char is unsigned" in the subject
line?

Am Freitag, den 04.11.2016, 16:18 +0100 schrieb Stefan Pöschel:
> One way to fix this is to make the struct variable sbr_present_flag
> signed.
> Another way is to enforce signed char by compiling FAAD2 with
> -fsigned-char.

I see that the fix is rather trivial, but wouldn't it introduce an ABI
(not API) break?

 - Fabian
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYHjQrAAoJEMvqjpcMzVnfgkoQAOMWHhbkhl5QJ4c+O3EEmtBQ
Doyz8HezqGLWud0PmHf9YOO7EK+gQusqN/3M/T/Qpe0/xbRE35ZiDO1kxNmiZk0O
OPdrihKkSF5LWbYqJE3QgZ9gRcFtWx0OB4YeVkjoCTi+bhEPDwPrzxLQtAo2sqtB
Sf39DsK6++zQfQNAzyxRZyVw6oKg9B9XuDblFcNUD16MgOCxlVlTswVR2iCD0+Pd
299geikSfG292LrFGiZD8PBE9S961mt4QXDAtcEdiznKrI6oZRpyShOPWWQPyqqm
x6y/MlatAUeBEXfngRibdxyIT23edZUPAhyfvuhD0blgB5cYYYHZ/vKnXZjfEurA
lEpor/KZA9QueKt31nLN5cpFPOGN5DtQX9Sy7AG9Cthcqyky9BWK2FnEEd8YFsYL
NgJa4kbFEYbOl1UnBbSarQz8g69tXcfk2gshzJvU/+SaQKNEsyBrLoWNen9gkYEd
c+3z0TPBAXVNw/MNA8LASapRPU6SLT7liqnb+RkdNB8Qnj+HLkwtWQyq67o+O9de
UvU2jXkwCK4tTSjM++fMRKJFSAV7aCFQR4KeGrvfPDz9E89rkzPwPeI6uUnGSaND
hYnYBGAPLZ37eDYA2uUkSf0ShGJn/OGOcyIyGji9XJyeWBKfewBG3KGO/JpNsSHB
Aw1oAfQjVWnAoWuGfSal
=wauB
-----END PGP SIGNATURE-----