liblscp -packaging

[James Cowgill]

Hi,

On 16/11/16 08:02, Jaromír Mikeš wrote:
> 2016-11-15 23:42 GMT+01:00 James Cowgill <jcowgill at debian.org>:
>> On 15/11/16 12:28, Ondrej Novy wrote:
>>> 2016-11-15 11:47 GMT+01:00 Jaromír Mikeš <mira.mikes at gmail.com>:
>>>> after building liblscp some files gets deleted
>>>
>>> i would use extend-diff-ignore in d/source/options, because it looks
>>> like "just cache". Maybe upstream should remove this files from release too.
>>
>> I don't think that option is applicable here. dpkg-source by default
>> already ignores deleted files which are present in the orig tarball.
>> There's nothing needed to get dpkg-source to work.
>>
>> I'm not sure how you'd get git-buildpackage to ignore just this
>> directory though. Usually I just ignore stuff like this and 'git
>> checkout --' whenever I need to use gbp. Try and get upstream to remove
>> it in the next release.
> 
> thank you!
> liblscp ready is for upload now.

A few comments (and sorry I've been quite busy this past week):

I don't understand why you have now decided to repack the source. Why do
you need to remove autom4te.cache? The build works fine even with it.

You could remove 01-makefiles.patch.

Since this is a C library, you should add a symbols file.

dh --with autoreconf is not needed with compat 10

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20161123/738b4cb2/attachment-0001.sig>