QA - bristol

[James Cowgill]

Hi,

On 06/09/16 20:24, Herbert Fortes wrote:
> I maintain one package for Multimedia Maintainers
> and did a search looking for something to do for
> the team.
> 
> I found bristol[0] with a RC-bug[1] with a patch
> to fix it. Can I check the package and do the upload
> if the patch works ? The patch made by Adrian Bunk <bunk at stusta.de>:

Sure. I don't think anyone will mind you fixing RC bugs in packages
which don't seem to get a lot of maintenance :)

The patch looks fine, although I don't know why we need to keep the
commented out #include. I would just remove the ifdef (3 lines).

James

> Description: Stop using alsa/iatomic.h
>  Technically this is an API breakage in libasound 1.1.2,
>  but it makes sense to me that this header was removed
>  by ALSA upstream.
>  .
>  bristol was the only user in Debian, and even here the
>  code that once used it was already commented out.
> Author: Adrian Bunk <bunk at stusta.de>
> Bug-Debian: https://bugs.debian.org/834180
> Forwarded: no
> 
> --- bristol-0.60.11.orig/libbristolaudio/audioEngineJack.c
> +++ bristol-0.60.11/libbristolaudio/audioEngineJack.c
> @@ -39,7 +39,7 @@
>  
>  #ifdef _BRISTOL_JACK
>  #if (BRISTOL_HAS_ALSA == 1)
> -#include <alsa/iatomic.h>
> +//#include <alsa/iatomic.h>
>  #endif
>  
>  /*


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160909/ad62e5ab/attachment.sig>