Bug#837566: mjpegtools: FTBFS with bindnow and PIE enabled

[Balint Reczey]

Source: mjpegtools
Version: 2.1.0+debian-4
Severity: important
User: balint at balintreczey.hu
Usertags: pie-bindnow-20160906
Justification: FTBFS on amd64 with extra hardening

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64 with patched GCC and dpkg.

The rebuild tested if packages are ready for a transition
enabling PIE and bindnow for amd64.

For more information about the changes to sid's dpkg and GCC please
visit:
 https://wiki.debian.org/Hardening/PIEByDefaultTransition

Relevant part (hopefully):
...
gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I../utils -Wdate-time
-D_FORTIFY_SOURCE=2 -fno-PIC -g -O2
-fdebug-prefix-map=/<<BUILDDIR>>/mjpegtools-2.1.0+debian=.
-fstack-protector-strong -Wformat -Werror=format-security -pthread -Wall
-Wunused -c -o yuvscaler-yuvscaler_resample.o `test -f
'yuvscaler_resample.c' || echo './'`yuvscaler_resample.c
gcc -DHAVE_CONFIG_H -I. -I..  -I.. -I../utils -Wdate-time
-D_FORTIFY_SOURCE=2 -fno-PIC -g -O2
-fdebug-prefix-map=/<<BUILDDIR>>/mjpegtools-2.1.0+debian=.
-fstack-protector-strong -Wformat -Werror=format-security -pthread -Wall
-Wunused -c -o yuvscaler-yuvscaler_bicubic.o `test -f
'yuvscaler_bicubic.c' || echo './'`yuvscaler_bicubic.c
/bin/bash ../libtool  --tag=CC   --mode=link gcc -fno-PIC -g -O2
-fdebug-prefix-map=/<<BUILDDIR>>/mjpegtools-2.1.0+debian=.
-fstack-protector-strong -Wformat -Werror=format-security -pthread -Wall
-Wunused  -Wl,-z,relro -Wl,-z,now -o yuvscaler yuvscaler-yuvscaler.o
yuvscaler-yuvscaler_resample.o yuvscaler-yuvscaler_bicubic.o
../utils/libmjpegutils.la  -lm  -lm libtool: link: gcc -fno-PIC -g -O2
-fdebug-prefix-map=/<<BUILDDIR>>/mjpegtools-2.1.0+debian=.
-fstack-protector-strong -Wformat -Werror=format-security -pthread -Wall
-Wunused -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/yuvscaler
yuvscaler-yuvscaler.o yuvscaler-yuvscaler_resample.o
yuvscaler-yuvscaler_bicubic.o  ../utils/.libs/libmjpegutils.so -lm -pthread
/usr/bin/ld: yuvscaler-yuvscaler.o: relocation R_X86_64_32 against
`.rodata.str1.8' can not be used when making a shared object; recompile
with -fPIC
/usr/bin/ld: yuvscaler-yuvscaler_resample.o: relocation R_X86_64_32
against `.rodata.str1.8' can not be used when making a shared object;
recompile with -fPIC
/usr/bin/ld: yuvscaler-yuvscaler_bicubic.o: relocation R_X86_64_32
against `.rodata.str1.8' can not be used when making a shared object;
recompile with -fPIC
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
Makefile:441: recipe for target 'yuvscaler' failed
make[3]: *** [yuvscaler] Error 1
make[3]: Leaving directory '/<<BUILDDIR>>/mjpegtools-2.1.0+debian/yuvscaler'
Makefile:572: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
...

The full build log is available from:
 https://people.debian.org/~rbalint/build-logs/pie-bindnow-20160906/mjpegtools_2.1.0+debian-4_amd64.build.gz

Thanks,
Balint