Bug#871649: lv2-dev: abuse of non portable pointer of uint8_t type

Joël Krähemann jkraehemann at gmail.com
Thu Aug 10 14:23:11 UTC 2017


Hi James,

It is common that you use for storing uint8_t an entire word.
The use of a uint8_t pointer confused me as you are pointing
to a struct.

Bests,
Joël


On Thu, Aug 10, 2017 at 4:10 PM, James Cowgill <jcowgill at debian.org> wrote:
> Hi,
>
> On 10/08/17 08:31, Joël Krähemann wrote:
>> Package: lv2-dev
>> Version: 1.14.0~dfsg1-1
>> Severity: important
>>
>> Dear Maintainer,
>>
>> The following header makes use of smallest possible pointer in LV2_Event_Buffer struct's data field.
>>
>> lv2/lv2plug.in/ns/ext/event/event.h
>>
>> Please change it to biggest possible pointer. It should be definitely void* type because the memory
>> pointed by data shall contain another struct LV2_Event.
>>
>> This describes an integer overflow. There shouldn't be any overflow.
>
> I'm afraid I don't see what the problem is here, or where the integer
> overflow is. The data field is casted to an appropriate pointer type
> whenever it is used and doing that is portable if you're careful.
>
> Thanks,
> James
>



More information about the pkg-multimedia-maintainers mailing list