Bug#872586: drumgizmo: FTBFS on several arches because of test failures

[James Cowgill]

Hi,

On 18/08/17 21:32, Jeremy Bicha wrote:
> Source: drumgizmo
> Version: 0.9.14-2
> Severity: serious
> 
> drumgizmo fails to build from source on several release architectures
> that it used to build on because of test failures.
> 
> https://buildd.debian.org/status/package.php?p=drumgizmo

The attached patch does not fix all the test failures, but does fix the
3 affecting mips, and this should be enough to fix armel and mipsel as
well. Things are still broken on mips64el and s390x after this.

src/atomic.h:
This fixes enginetest by removing the assertion. My guess is that the
writer of the code meant to say "does this atomic use the std::atomic
implementation" (as opposed to the other implementation in src/atomic.h)
but instead said "is this atomic lock free" assuming that all
std::atomics are always lock free...

test/atomictest.cc:
Fixes atomictest by removing the test for lock free atomics. One some
architectures isLockFree may legitimately return false (eg it is
impossible to make atomic<long int> lock free on 32-bit mips). The test
was probably added with the same assumption as above.

plugingui/image.cc:
Fixes imagecachetest. The original code was not big-endian safe. Replace
the memcpy with shifts and ORs.

Thanks,
James
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mips.patch
Type: text/x-patch
Size: 2215 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170819/8686978a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170819/8686978a/attachment.sig>