[SCM] ardour/master: Modernize cdbs: Do copyright-check in maintainer script (not during build).

[Jonas Smedegaard]

Quoting Jaromír Mikeš (2017-08-21 16:35:39)
> 2017-08-21 15:13 GMT+02:00 Jonas Smedegaard <dr at jones.dk>:
> 
> > Quoting Jaromír Mikeš (2017-08-21 14:37:25)
> > > 2017-08-21 14:07 GMT+02:00 Jonas Smedegaard <dr at jones.dk>:
> > > > The script works for me - just tested again.  Could you please tell
> > > > exactly which commands you invoked which lead to "Nothing".
> > > >
> > >
> > > Well "nothing" was not precise ... :(
> > >
> > > $ debian/copyright-check
> > > CDBS: parsing Ardour-5.11.0.tar.bz2 ...
> > > Parsing Ardour-5.11.0.tar.bz2...
> > >
> > > bzip2: Compressed file ends unexpectedly;
> > >     perhaps it is corrupted?  *Possible* reason follows.
> > > bzip2: Inappropriate ioctl for device
> > >     Input file = (stdin), output file = (stdout)
> > >
> > > It is possible that the compressed file(s) have become corrupted.
> > > You can use the -tvv option to test integrity of such files.
> > >
> > > You can use the `bzip2recover' program to attempt to recover
> > > data from undamaged sections of corrupted files.
> >
> > Looks like source should be fixed to not include an empty tarball.
> >
> 
> Ohh  :(
> 
> > Can't locate Image/ExifTool.pm in @INC (you may need to install the
> > > Image::ExifTool module)
> >
> > apt install libimage-exiftool-perl
> >
> > (similar for other Perl modules)
> >
> 
> Thank you Jonas now it works ... copyright_hints now contains a lot of
> "FIXME" entries.
> It's giving a lot of lintian errors ... could this be fixed by improving
> script or it need to be fixed manually?

The very _purpose_ of the copyright_hints file is to _hint_ about 
copyright and licensing information, and to distinguish hints from facts 
- i.e. to avoid maintainers blindly trusting the hints by copying over 
to copyright file without double-checking - I invented the pattern of 
adding a FIXME.

It is therefore a good thing that lintian nowadays check and complain if 
copyright file has FIXME entries, but it is a bug that it complains 
about FIXME entries in copyright_hints file.

So no, this should not be addressed in script nor by hand.  It should be 
fixed in lintian: Someone (you, if you agree with above) should file a 
bugreport against lintian requesting that it limits the FIXME check to 
the copyright file (or at least make an explicit excemption for 
debian/copyright_hints).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170821/14aa5652/attachment.sig>