Bug#873161: zita-convolver FTCBFS: binutils dependency unsatisfiable, uses build architecture compiler

[Helmut Grohne]

Source: zita-convolver
Version: 3.1.0-5
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

zita-convolver fails to cross build from source for multiple reasons:

 * Its binutils build-dependency (host architecture) conflicts with the
   binutils dependncy from build-essential. In theory, we'd have to
   apply "toolchain dependency cross translation", but it is much easier
   to simply drop the redundant dependency.
 * The upstream Makefile hard codes g++ (build architecture compiler).

After fixing both issues, zita-convolver cross builds successfully.
Please consider applying the attached patch.

Helmut
-------------- next part --------------
diff --minimal -Nru zita-convolver-3.1.0/debian/changelog zita-convolver-3.1.0/debian/changelog
--- zita-convolver-3.1.0/debian/changelog	2016-12-27 13:53:40.000000000 +0100
+++ zita-convolver-3.1.0/debian/changelog	2017-08-25 07:27:37.000000000 +0200
@@ -1,3 +1,12 @@
+zita-convolver (3.1.0-5.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    * Drop implicitly satisfied binutils build dependency.
+    + Make g++ substitutable in Makefile.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Fri, 25 Aug 2017 07:27:37 +0200
+
 zita-convolver (3.1.0-5) unstable; urgency=medium
 
   * Set dh/compat 10.
diff --minimal -Nru zita-convolver-3.1.0/debian/control zita-convolver-3.1.0/debian/control
--- zita-convolver-3.1.0/debian/control	2016-12-27 13:53:30.000000000 +0100
+++ zita-convolver-3.1.0/debian/control	2017-08-25 07:27:25.000000000 +0200
@@ -6,7 +6,6 @@
  Free Ekanayaka <freee at debian.org>,
  Jarom??r Mike?? <mira.mikes at seznam.cz>
 Build-Depends:
- binutils,
  debhelper (>= 10),
  libfftw3-dev (>= 3.1.2-3.1)
 Standards-Version: 3.9.8
diff --minimal -Nru zita-convolver-3.1.0/debian/patches/makefile.patch zita-convolver-3.1.0/debian/patches/makefile.patch
--- zita-convolver-3.1.0/debian/patches/makefile.patch	2012-09-01 12:25:45.000000000 +0200
+++ zita-convolver-3.1.0/debian/patches/makefile.patch	2017-08-25 07:27:37.000000000 +0200
@@ -34,7 +34,16 @@
  LDLFAGS += 
  LDLIBS +=
  
+@@ -47,7 +46,7 @@
+ 
+ 
+ $(ZITA-CONVOLVER_MIN):	$(ZITA-CONVOLVER_O)
+-	g++ -shared $(LDFLAGS) -Wl,-soname,$(ZITA-CONVOLVER_MAJ) -o $(ZITA-CONVOLVER_MIN) $(ZITA-CONVOLVER_O) $(ZITA-CONVOLVER_DEP)
++	$(CXX) -shared $(LDFLAGS) -Wl,-soname,$(ZITA-CONVOLVER_MAJ) -o $(ZITA-CONVOLVER_MIN) $(ZITA-CONVOLVER_O) $(ZITA-CONVOLVER_DEP)
+ 
+ 
+ install:	$(ZITA-CONVOLVER_MIN)
 @@ -55,8 +54,8 @@ install:	$(ZITA-CONVOLVER_MIN)
  	install -d $(DESTDIR)$(PREFIX)/$(LIBDIR)
  	install -m 644 $(ZITA-CONVOLVER_H) $(DESTDIR)$(PREFIX)/include
  	install -m 755 $(ZITA-CONVOLVER_MIN) $(DESTDIR)$(PREFIX)/$(LIBDIR)