yoshimi_1.5.6-1_amd64.changes REJECTED

[Mattia Rizzolo]

On Wed, Dec 20, 2017 at 03:39:29PM +0100, Jaromír Mikeš wrote:
> Ok ... I beleave it is fixed now in our git repo.
> Mattia can you check it and upload again please?

I haven't looked at the whole d/copyright, but just looking at a small
commit:

--- a/debian/copyright
+++ b/debian/copyright
@@ -103,9 +103,10 @@ Copyright: 2011, Alan Calvert
            2014-2017, Will Godfrey
 License: GPL-3+

-Files: banks/Drums/0004-Natural Drum Kit.xiz
-       banks/Drums/0005-Natural Snare - variable deca.xiz
-       banks/Drums/0006-HiHat closed - variable decay.xiz
+Files: banks/Drums/0004-Natural?Drum?Kit.xiz
+       banks/Drums/0005-Natural?Snare?-?variable?deca.xiz
+       banks/Drums/0006-HiHat?closed?-?variable?decay.xiz
+Copyright: no-copyright
 License: GPL-3

 Files: src/Misc/Config.cpp
@@ -122,6 +123,7 @@ License: GPL-2+ or LGPL-2+

 Files: Util/YoshimiSplash.svg
        Util/splashreference.svg
+Copyright: no-copyright
 License: CC-BY

That's not going to fly:
* "no-copyright" is hardly a copyright holder (which afaik is "required"
  by both GPL-3 and CC-*
* CC-BY: what version?  you dumped a whole license text, so I guess you
  know what the answer
* peaking further I see that you included the COPYING file as a
  copyrighted thing in the paragraph at line 99; whilst due to the
  initial Files:* it's included anyway, I don't think it should stay in
  a paragraph of its own, I'm pretty sure the GPL-2/3 text is not
  copyrighted by those two guys; besides, 'License: GPL-3+' for the
  GPL-2 text :P

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20171220/fe02fcb3/attachment.sig>