gwc - package review

[James Cowgill]

Hi,

On 19/07/17 09:36, Jaromír Mikeš wrote:
> I just updated gwc package - but there are still some minor issues.
> Would be great if someone could review it and help to fix them.

I assume you've seen #868841 (which is not a minor issue).

> 1) package is renamed from gwc (gnome-wave-cleaner) to gtk-wave-cleaner
> what leads to some issues
> W: gwc: duplicate-changelog-files
> usr/share/doc/gtk-wave-cleaner/Changelog.gz usr/share/doc/gwc/changelog.gz
> W: gwc: extra-license-file usr/share/doc/gtk-wave-cleaner/COPYING.gz

Err you haven't renamed the package. You should be installing all
documentation into /usr/share/doc/<package>

> 2) I guess some flags are not passed correctly and dbgsym package is not
> build.

The upstream install script strips the binary:
> install -p -s gtk-wave-cleaner "/<<PKGBUILDDIR>>/debian/tmp"/usr/bin

(remove the -s option)

James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170719/7154d07f/attachment-0001.sig>