avldrums.lv2 - DD upload

[Jaromír Mikeš]

2017-06-26 11:26 GMT+02:00 James Cowgill <jcowgill at debian.org>:

Hi James,

thank you for reviewing this package.

>     here is one last minute package ;)
> >     Can someone review and upload this package to NEW please?
> >     Would be great if this would slip in before freeze ;)
> >
> > Can someone upload avldrums.lv2 package now for me please?
>
> debian/rules:
> > ifeq ($(DEB_HOST_ARCH_CPU),amd64)
> > export OPTIMIZATIONS += -msse -msse2 -mfpmath=sse
> > endif
>
> You should be able to remove this bit. Those 3 options are already
> enabled by default on amd64.
>

Done!


> > override_dh_auto_clean:
> >
>
> Why?
>

This helped me avoid build problem described on the end of your message ...
Removed now.


> > override_dh_auto_configure:
> >       dh_auto_configure -- \
> >               --prefix=/usr
>
> dh_auto_configure is a no-op for "Makefile only" packages.
>

Fixed!

>
> > override_dh_auto_build:
> >       $(MAKE) \
> >               PREFIX=/usr
>
> You should use "dh_auto_build -- PREFIX=/usr" so parallel builds work
>

Done!


> > override_dh_auto_install:
> >       $(MAKE) install \
> >               DESTDIR=$(CURDIR)/debian/tmp \
> >               PREFIX=/usr
>
> And "dh_auto_install" here.
>

Done!


> debian/watch file seems to be broken?
>

Fixed!


> the "fluidsynth" and "robtk" directories look like external modules and
> should be de-bundled.
>

I have discussed this with upstream before ...
here is answer ... (  same might go for robtk? )
------------------

> Is there some way use rather system-wide fluidsynth lib?

No (same with Ardour btw). It's a stripped down and patched dedicated
version and statically linked with hidden symbols.

Pro Audio Plugins should be self-contained and not rely on any system
libs except for libc (and libX11/xcb which needs to match the X11 server
ABI).

There are too many things that can go wrong otherwise (calf is the prime
example). e.g. update fftw or mix some random pango/cairo/pixman or even
just freetype version and you'll throw thread safety out of the window.
Any lib that uses a lock to maintain some global cache will void
realtime safety as well.  default fluidsynth falls in that category as
well:  .sf2 files are cached globally and a lock is used.

Remember, plugins are loaded in the same memory space as the host, which
may also use those libs. They're not standalone process separated apps.
Ideally plugins are self-contained and don't share any libs with the host.

If 2 unrelated plugins were to use the same shared libfludsynth various
edge cases can happen since the plugins don't know about each other.

Also related is exception handling in this case (setjmp/longjmp). At
least for rolling distros (e.g. debian/testing) where a library can be
compiled with a different compiler version than the plugin and host.
--------------



> I see the -data package just contains some soundfonts. Would it be
> sensible to put these in the "public" soundfont directory
> (/usr/share/sounds/sf2) or are they only usable with avldrums?
>

Probably they are usable just with avldrums, but I can ask upstream.

Building in git:
> > Version: debian/0.2.2-1-9 -> debian/0-9 debian/2-9 debian/2-9 debian/1-9
> > expr: non-integer argument
> > git2lv2.mk:37: *** "Cannot extract required LV2 minor-version
> parameter".  Stop.
>
> While this only happens when using git, it is very frustrating. I think
> you should override the "avldrums_VERSION" variable to fix it.
>

Can you elaborate here? I am not sure how to fix this :(

I haven't done an indepth copyright check, but I can't seen any obvious
> problems.
>

Ok ...

best regards

mira
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170626/a22080f4/attachment.html>