Bug#875192: [simplescreenrecorder] Future Qt4 removal from Buster

[James Cowgill]

Hi,

On 26/11/17 13:27, Lisandro Damián Nicanor Pérez Meyer wrote:
> El 26 nov. 2017 10:24 a.m., "Lisandro Damián Nicanor Pérez Meyer" <
> perezmeyer at gmail.com> escribió:
> 
> El 26 nov. 2017 10:22 a.m., "James Cowgill" <jcowgill at debian.org> escribió:
> 
> Hi,
> [...]
> 
>> The only minor thing I noted is that QPainter is included twince in
> 0003*, but
>> definitely nothing to worry too much.
> 
> I have applied the patches with some slight modifications:
> - Remove the duplicate QPainter include.
> - Use DEB_CXXFLAGS_MAINT_APPEND instead of overriding QT5_CFLAGS.
> 
> 
> It might be worth to note that that
> 
> My son little G came and pressed the right key to send the mail ;-)

Not to worry :)

> I was about to write that that flag should be already present if the
> project is using cmake or qmake. I have not checked the build system.

The build system is autotools and it uses pkg-config to discover all the
Qt libs and cflags etc. I did do some Google searching and I did notice
that CMake would fix this up for you, but I couldn't find anything about
this with autotools. I think adding -fPIC is fine for the moment, even
if it's only a workaround.

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20171126/e434ec3b/attachment.sig>