Bug#878324: directfb: Linux-specific libraries like *_fbdev.so are not included in libdirectfb-bin arm builds

[Keith Kyzivat]

Source: directfb
Version: 1.2.10.0-8
Severity: important
Tags: patch

Dear Maintainer,

When installing the Debian Stretch directfb package on an embedded
armhf platform that has no X-Windows, I encountered both my
application, and the dfbinfo application failing because it failed to 
find the systems/libdirectfb_fbdev.so systems library, and was instead
falling back and attempting to load the X11 systems library. This
failed because I do not have (nor desire to have) X11 configured on
this system.

So, in short, the problem is that
/usr/lib/arm-linux-gnueabihf/directfb-1.2.9/systems/libdirectfb_fbdev.so
is not installed, and thus using DirectFB with a framebuffer does not function,
despite the support being built into DirectFB.

I expect that /usr/lib/arm-linux-gnueabihf/directfb-1.2.9/systems/libdirectfb_fbdev.so
should be installed.

I investigated, and found sid's version of the directfb package
includes systems/libdirectfb_fbdev.so - and found the commit that
fixed the issue there - this is essentially a backport of that fix:
https://anonscm.debian.org/cgit/pkg-multimedia/directfb.git/commit/debian/libdirectfb-1.7-7.install?h=debian/1.7.7-6&id=d8c1e58e5e9ec7458888781f50d4f7b1ce2cc19c

I dug around the commits from the directfb Stretch release and found
related commits that introduced the breakage (fixing non-linux installs):
https://anonscm.debian.org/cgit/pkg-multimedia/directfb.git/commit/?h=debian/1.2.10.0-8&id=699a54bed0cceb20b70a8e674493e110e13b9949
https://anonscm.debian.org/cgit/pkg-multimedia/directfb.git/diff/debian/libdirectfb-1.2-9.install?h=debian/1.2.10.0-8&id=c99b82a0575a1e8af7c6b4d32520eee90ae03ade

The fix for this is to modify the lines in the installation file
debian/libdirectfb-1.2-9.install changing the '[linux]' prefixed lines
to '[linux-any]'. This directs the build tools to package the matching
files when building for any Linux platforms. I'm not sure what [linux]
without the -any part actually means.

I have a patch file I have tested that fixes this.


-- System Information:
Debian Release: 9.1
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: armhf (armv7l)

Kernel: Linux 4.4.0-xilinx-dirty (SMP w/1 CPU core; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru directfb-1.2.10.0/debian/changelog directfb-1.2.10.0/debian/changelog
--- directfb-1.2.10.0/debian/changelog	2017-01-01 07:58:58.000000000 -0500
+++ directfb-1.2.10.0/debian/changelog	2017-10-12 13:50:41.000000000 -0500
@@ -1,3 +1,10 @@
+directfb (1.2.10.0-8.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Install linux specific files for any linux builds [linux-any]
+
+ -- Sebastian Ramacher <ares at ares-205>  Thu, 12 Oct 2017 13:50:41 -0500
+
 directfb (1.2.10.0-8) unstable; urgency=medium
 
   * debian/*.install: Also install davinci_c64x on armhf.
diff -Nru directfb-1.2.10.0/debian/libdirectfb-1.2-9.install directfb-1.2.10.0/debian/libdirectfb-1.2-9.install
--- directfb-1.2.10.0/debian/libdirectfb-1.2-9.install	2017-01-01 07:54:27.000000000 -0500
+++ directfb-1.2.10.0/debian/libdirectfb-1.2-9.install	2017-10-12 13:50:41.000000000 -0500
@@ -1,13 +1,13 @@
 #! /usr/bin/dh-exec
-[linux] usr/lib/*/directfb-*/*drivers/*.so
+[linux-any] usr/lib/*/directfb-*/*drivers/*.so
 usr/lib/*/directfb-*/interfaces/IDirectFBFont/libidirectfbfont_default.so
 usr/lib/*/directfb-*/interfaces/IDirectFBFont/libidirectfbfont_dgiff.so
 usr/lib/*/directfb-*/interfaces/IDirectFBImageProvider/libidirectfbimageprovider_dfiff.so
 usr/lib/*/directfb-*/interfaces/IDirectFBImageProvider/libidirectfbimageprovider_gif.so
 usr/lib/*/directfb-*/interfaces/IDirectFBVideoProvider/libidirectfbvideoprovider_gif.so
-[linux] usr/lib/*/directfb-*/interfaces/IDirectFBVideoProvider/libidirectfbvideoprovider_v4l.so
+[linux-any] usr/lib/*/directfb-*/interfaces/IDirectFBVideoProvider/libidirectfbvideoprovider_v4l.so
 usr/lib/*/directfb-*/systems/libdirectfb_devmem.so
-[linux] usr/lib/*/directfb-*/systems/libdirectfb_fbdev.so
+[linux-any] usr/lib/*/directfb-*/systems/libdirectfb_fbdev.so
 usr/lib/*/directfb-*/wm/libdirectfbwm_default.so
 usr/lib/*/directfb-*/wm/libdirectfbwm_unique.so
 usr/lib/*/libdirectfb-*.so.*