Bug#853560: mp4v2: ftbfs with GCC-7

Philip Chung philipchung1995 at yahoo.com
Mon Sep 4 16:07:19 UTC 2017


Control: tags -1 patch

On Tue, 31 Jan 2017 09:34:07 +0000 Matthias Klose <doko at debian.org> wrote:
> Package: src:mp4v2
> Version: 2.0.0~dfsg0-5
> Severity: normal
> Tags: sid buster
> User: debian-gcc at lists.debian.org
> Usertags: ftbfs-gcc-7
> 
> Please keep this issue open in the bug tracker for the package it
> was filed for.  If a fix in another package is required, please
> file a bug for the other package (or clone), and add a block in this
> package. Please keep the issue open until the package can be built in
> a follow-up test rebuild.
> 
> The package fails to build in a test rebuild on at least amd64 with
> gcc-7/g++-7, but succeeds to build with gcc-6/g++-6. The
> severity of this report may be raised before the buster release.
> There is no need to fix this issue in time for the stretch release.
> 
> The full build log can be found at:
> http://people.debian.org/~doko/logs/gcc7-20170126/mp4v2_2.0.0~dfsg0-5_unstable_gcc7.log
> The last lines of the build log are at the end of this report.
> 
> To build with GCC 7, either set CC=gcc-7 CXX=g++-7 explicitly,
> or install the gcc, g++, gfortran, ... packages from experimental.
> 
>   apt-get -t=experimental install g++ 
> 
> Common build failures are new warnings resulting in build failures with
> -Werror turned on, or new/dropped symbols in Debian symbols files.
> For other C/C++ related build failures see the porting guide at
> http://gcc.gnu.org/gcc-7/porting_to.html
> 
> [snip]

Attached is a patch that fixes the compilation error. The package now
builds on my amd64 system.

The error occurs because a pointer is compared with the character
constant '\0' as opposed to 0. An initial reading of the code suggests
that the intent was to dereference the pointer first. The attached patch
dereferences the pointer as I've described.

Philip Chung
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pointer-comparison.patch
Type: text/x-patch
Size: 736 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20170904/393d2101/attachment.bin>


More information about the pkg-multimedia-maintainers mailing list