Bug#872674: puredata-import FTBFS with puredata 0.48.0-1

[Philip Chung]

Control: tags -1 patch

On Sun, 20 Aug 2017 03:30:19 +0300 Adrian Bunk <bunk at debian.org> wrote:
> Source: puredata-import
> Version: 1.3-3
> Severity: serious
> Tags: buster sid
> 
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/puredata-import.html
> 
> ...
> make -j1
> make[1]: Entering directory '/build/1st/puredata-import-1.3'
> cc -I"/usr/include/pd" -Wall -W -g -DPD -DVERSION='"1.3"' -fPIC -O6 -funroll-loops -fomit-frame-pointer -o "import.o" -c "import.c"
> In file included from import.c:2:0:
> s_stuff.h:48:12: error: conflicting types for 'sys_hostfontsize'
>  EXTERN int sys_hostfontsize(int fontsize);
>             ^~~~~~~~~~~~~~~~
> In file included from import.c:1:0:
> /usr/include/pd/m_pd.h:436:12: note: previous declaration of 'sys_hostfontsize' was here
>  EXTERN int sys_hostfontsize(int fontsize, int zoom);
>             ^~~~~~~~~~~~~~~~
> import.c: In function 'import_new':
> import.c:112:12: warning: unused variable 'currentdir' [-Wunused-variable]
>   t_symbol *currentdir;
>             ^~~~~~~~~~
> import.c:109:35: warning: unused parameter 's' [-Wunused-parameter]
>  static void *import_new(t_symbol *s, int argc, t_atom *argv)
>                                    ^
> import.c: In function 'import_free':
> import.c:138:35: warning: unused parameter 'x' [-Wunused-parameter]
>  static void import_free(t_import *x)
>                                    ^
> Makefile:191: recipe for target 'import.o' failed
> make[1]: *** [import.o] Error 1
> 
> 

The solution is to simply remove debian/patches/add_required_headers.h

The Debian packages for Pure Data now include the required headers, and
the local headers added in the patch are now out of sync.

Philip Chung