First commit to salsa (ebumeter packaging)

trebmuh at tuxfamily.org trebmuh at tuxfamily.org
Thu Apr 19 18:36:16 BST 2018


Le 2018-04-19 18:31, James Cowgill a écrit :
> Hi,
> 
> Note the the correct list is "debian-multimedia at lists.debian.org".
> "pkg-multimedia-maintainers at lists.alioth.debian.org" is going away, so
> we should stop using it.

Noted.



> On 19/04/18 16:47, trebmuh at tuxfamily.org wrote:
>> Hi all
>> 
>> This is my first commits on salsa so any advice is welcome. See here
>> https://salsa.debian.org/multimedia-team/ebumeter/commits/master .
>> 
>> I did that using the web on-line interface since it is only small
>> changes on debian/ files which *shouldn't* modify the actual build.
> 
> Ok, the change looks fine.

OK. Thanks.



>> That said, because I didn't test a rebuild on a local Sid/Buster
>> machine, I set d/control to UNRELEASED since I understand this will 
>> not
>> trigger automatically a buildfarm-rebuild and it will wait for the
>> debian/control "UNRELEASED" to be replaced by "unstable" to trigger a
>> rebuild.
> 
> No, you need someone to upload the package for you - changing the
> changelog in git won't actually do anything. Leaving it as UNRELEASED 
> is
> fine for the moment though.

OK. That make sense. I might have dreamed about automatic-rebuild, my 
bad.



> Usually the workflow is:
> - Add a new changelog entry marked as UNRELEASED
> - Do you changes without modifying the changelog
> - At the end, update the changelog and set the distribution to unstable
> - Upload the package (or in your case ask someone to do this for you).
> 
> This makes it easier to cherry pick commits, and ensures the version is
> still correct in the middle of development.

OK, noted.



>> In my opinion, such a small update doesn't need a rebuild now, but 
>> would
>> deserve a rebuild before the Buster freeze in order to reach the 
>> future
>> buster-stable pool. In consequence, before the future Buster freeze, 
>> I'm
>> intending to have a look at this modification to this package if 
>> nobody
>> has uploaded it by then by:
>> - testing a pbuilder rebuild on a local sid/buster machine
>> - then, after checking that it rebuild and behave correctly, doing the
>> move (UNRELEASED -> unstable) myself in order to trigger a rebuild for
>> it to be on the next Debian "Buster" stable version
> 
> This is fine, but again you need to get a DD (or DM for some packages)
> to do the actual upload.

OK.



>> If I understand the multimedia-team packaging process correctly, I'll
>> then need to add myself as "uploader" in d/control before setting it 
>> to
>> "unstable".
> 
> You don't need to do that. The "Uploaders" field contains the usual
> maintainers of the package, but if you don't intend to do continual
> maintenance, you can do a "Team upload". Example:
> 
> https://tracker.debian.org/news/879093/accepted-drumgizmo-0914-3-source-into-unstable/

OK.



>> I've got other small improvements to make to a few package (managed by
>> debian-multimedia) and I would appreciate if you, knowledgeable 
>> people,
>> can confirm/infirm that the way I'm doing this one is fine before I
>> start doing others.
> 
> Committing stuff to git is probably fine, as long as you are sure it's
> correct.
> 
> Thanks,
> James


Thank you very much for your answer James.
I'll keep going upating some packages on the times coming.

Cheers,
Olivier



More information about the pkg-multimedia-maintainers mailing list