Bug#906476: klystrack: FTBFS in buster/sid ('strncpy' output may be truncated)

[Santiago Vila]

Package: src:klystrack
Version: 0.20171212-3
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-arch
dh build-arch --sourcedirectory=klystrack
   dh_update_autotools_config -a -O--sourcedirectory=klystrack
   dh_autoreconf -a -O--sourcedirectory=klystrack
   dh_auto_configure -a -O--sourcedirectory=klystrack
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_build -- CFG=release
	cd klystrack && make -j1 "INSTALL=install --strip-program=true" CFG=release
make[2]: Entering directory '/<<PKGBUILDDIR>>/klystrack'
Generating dependencies for timer.c...
Generating dependencies for sequence.c...
Generating dependencies for pattern.c...
Generating dependencies for wavetableview.c...

[... snipped ...]

src/gui/filebox.c:722:8: warning: 'strncpy' specified bound 256 equals destination size [-Wstringop-truncation]
        strncpy(data.field, data.files[data.selected_file].name, sizeof(data.field));
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling msgbox.c...
Compiling mouse.c...
Compiling menu.c...
Compiling dialog.c...
Compiling toolutil.c...
Compiling shortcuts.c...
src/gui/shortcuts.c: In function 'get_shortcut_string':
src/gui/shortcuts.c:67:3: warning: 'strncat' specified bound 100 equals destination size [-Wstringop-overflow=]
   strncat(buffer, "ctrl-", sizeof(buffer));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/gui/shortcuts.c:70:3: warning: 'strncat' specified bound 100 equals destination size [-Wstringop-overflow=]
   strncat(buffer, "alt-", sizeof(buffer));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/gui/shortcuts.c:73:3: warning: 'strncat' specified bound 100 equals destination size [-Wstringop-overflow=]
   strncat(buffer, "shift-", sizeof(buffer));
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling bevel.c...
Linking engine...
make -C tools/makebundle 
make[5]: Entering directory '/<<PKGBUILDDIR>>/klystron/tools/makebundle'
gcc -o ../bin/makebundle.exe -D_XOPEN_SOURCE makebundle.c -std=c99 -I ../../src `sdl2-config --cflags` -Wall -O3
make[5]: Leaving directory '/<<PKGBUILDDIR>>/klystron/tools/makebundle'
make[4]: Leaving directory '/<<PKGBUILDDIR>>/klystron'
make[3]: Leaving directory '/<<PKGBUILDDIR>>/klystron'
make[3]: Entering directory '/<<PKGBUILDDIR>>/klystrack'
Generating dependencies for action.c...
Generating dependencies for main.c...
Generating dependencies for action.c...
Generating dependencies for main.c...
Compiling view.c...
src/view.c: In function 'info_line':
src/view.c:543:3: error: 'strncpy' output may be truncated copying 200 bytes from a string of length 255 [-Werror=stringop-truncation]
   strncpy(text, mused.info_message, sizeof text);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:158: objs.release/view.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/klystrack'
make[2]: *** [Makefile:137: build] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/klystrack'
dh_auto_build: cd klystrack && make -j1 "INSTALL=install --strip-program=true" CFG=release returned exit code 2
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:12: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -B" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/klystrack.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.