Bug#889032: pd-tclpd uses deprecated Tcl 8.5

[Sergei Golovan]

Source: pd-tclpd
Version: 0.3.0-1
Severity: important
Tags: patch

Dear Maintainer,

We are planning to remove Tcl 8.5 from Debian since it's reaced the
end-of-life. So please, switch pd-tclpd to a more recent Tcl version.

I'd like to propose a NMU which just replaces tcl8.6-dev by tcl-dev
(the default Tcl version, which is currently 8.6) and patches
Makefile to use it instead of 8.5. If it's okay to you, I could
dor the upload.

-- System Information:
Debian Release: 9.3
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'proposed-updates'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental'), (1, 'unstable'), (1, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-0.bpo.3-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
-------------- next part --------------
diff -Nru pd-tclpd-0.3.0/debian/changelog pd-tclpd-0.3.0/debian/changelog
--- pd-tclpd-0.3.0/debian/changelog	2015-08-18 00:58:39.000000000 +0300
+++ pd-tclpd-0.3.0/debian/changelog	2018-02-01 13:31:51.000000000 +0300
@@ -1,3 +1,11 @@
+pd-tclpd (0.3.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Switch to the default Tcl/Tk from Tcl/Tk 8.5 which is to be removed from
+    Debian.
+
+ -- Sergei Golovan <sgolovan at debian.org>  Thu, 01 Feb 2018 13:31:51 +0300
+
 pd-tclpd (0.3.0-1) unstable; urgency=medium
 
   * Initial release. (Closes: #795898)
diff -Nru pd-tclpd-0.3.0/debian/control pd-tclpd-0.3.0/debian/control
--- pd-tclpd-0.3.0/debian/control	2015-08-18 00:58:15.000000000 +0300
+++ pd-tclpd-0.3.0/debian/control	2018-01-20 09:40:48.000000000 +0300
@@ -6,7 +6,7 @@
  debhelper,
  dh-buildinfo,
  puredata-dev | puredata,
- tcl8.5-dev,
+ tcl-dev,
  swig
 Standards-Version: 3.9.6
 Section: sound
diff -Nru pd-tclpd-0.3.0/debian/control.in pd-tclpd-0.3.0/debian/control.in
--- pd-tclpd-0.3.0/debian/control.in	2015-08-18 00:49:54.000000000 +0300
+++ pd-tclpd-0.3.0/debian/control.in	2018-01-20 09:40:58.000000000 +0300
@@ -4,7 +4,7 @@
 Uploaders: IOhannes m zm?lnig (Debian/GNU) <umlaeute at debian.org>
 Build-Depends: @cdbs@,
  puredata-dev | puredata,
- tcl8.5-dev,
+ tcl-dev,
  swig
 Standards-Version: 3.9.6
 Section: sound
diff -Nru pd-tclpd-0.3.0/debian/patches/default-tcltk.patch pd-tclpd-0.3.0/debian/patches/default-tcltk.patch
--- pd-tclpd-0.3.0/debian/patches/default-tcltk.patch	1970-01-01 03:00:00.000000000 +0300
+++ pd-tclpd-0.3.0/debian/patches/default-tcltk.patch	2018-01-20 09:43:49.000000000 +0300
@@ -0,0 +1,19 @@
+--- a/Makefile
++++ b/Makefile
+@@ -38,14 +38,14 @@
+ #
+ #------------------------------------------------------------------------------#
+ 
+-ALL_CFLAGS = -I"$(PD_INCLUDE)" -std=c99 -I/usr/include/tcl8.5 \
++ALL_CFLAGS = -I"$(PD_INCLUDE)" -std=c99 -I/usr/include/tcl \
+ 	-I/Library/Frameworks/Tcl.framework/Headers \
+ 	-Wall -W -Wno-unused-parameter \
+ 	-DHASHTABLE_COPY_KEYS
+ ALL_LDFLAGS = -fPIC
+ SHARED_LDFLAGS =
+ ALL_LIBS = 
+-LIBS_linux = -ltcl8.5
++LIBS_linux = -ltcl
+ LIBS_macosx = -framework Tcl
+ LIBS_windows = -ltcl85 "$(LIBRARY_NAME).def"
+ 
diff -Nru pd-tclpd-0.3.0/debian/patches/series pd-tclpd-0.3.0/debian/patches/series
--- pd-tclpd-0.3.0/debian/patches/series	2015-08-18 00:43:54.000000000 +0300
+++ pd-tclpd-0.3.0/debian/patches/series	2018-01-20 09:43:01.000000000 +0300
@@ -1 +1,2 @@
 fix_format-security.patch
+default-tcltk.patch