Bug#888288: RFS: libheif/0.0.1+20180124133753+git68fb4fe-1 [ITP: #888278]

[Joachim Bauch]

Hi Sebastian,

thanks for your feedback, I uploaded a new version to mentors:
https://mentors.debian.net/debian/pool/main/libh/libheif/libheif_0.0.1+20180206084258+git9d8f256-1.dsc

Additional comments see below.

On 03.02.2018 14:47, Sebastian Ramacher wrote:
> That fails to build:
> 
> | g++ -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -I../src -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/libheif-0.0.1+20180124133753+git68fb4fe=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -Wsign-compare -Wconversion -Wno-sign-conversion -Wno-error=conversion -c -o heif_info-heif_info.o `test -f 'heif_info.cc' || echo './'`heif_info.cc
> | encoder_png.cc: In member function 'virtual bool PngEncoder::Encode(const heif_image_handle*, const heif_image*, const string&)':
> | encoder_png.cc:56:62: error: 'strerror' was not declared in this scope
> |      fprintf(stderr, "Can't open %s: %s\n", filename.c_str(), strerror(errno));
> |                                                               ^~~~~~~~
> | encoder_png.cc:56:62: note: suggested alternative: 'perror'
> |      fprintf(stderr, "Can't open %s: %s\n", filename.c_str(), strerror(errno));
> |                                                               ^~~~~~~~
> |                                                               perror
> | Makefile:553: recipe for target 'heif_convert-encoder_png.o' failed

Interesting, on Ubuntu the "string.h" seems to get pulled in by some
other header and it compiles fine. Anyway, this is fixed upstream and
I verified by building the package on sid.

> Some other issues:
> 
> * The library package should be named based on the SONAME, so that would be
>   libheif1.

Changed to "libheif-1", or should the name be without the dash?

> * Current Standards-Version is 4.1.3.

Changed, however the lintian on mentors now complains that the version
is too new: "newer-standards-version 4.1.3 (current is 3.9.8)"

> * If you bump debhelper compatibility to 10 or 11, you can drop the explicit
>   --with autreconf and --parallel in d/rules. You could also drop dh-autoreconf
>   from Build-Depends.

Nice, I bumped the compatibility to 10 in the updated package.

If everything looks good from a packaging side now, we will release
1.0.0 shortly and I will update the package with the release.

Thanks again and best regards,
  Joachim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20180206/9cb1e3e8/attachment.sig>