Bug#881342: rtkit: should depend on dbus and polkit

[James Cowgill]

Control: severity -1 serious
Control: retitle -1 rtkit: should depend on dbus and polkit

Hi,

On 05/02/18 15:18, Алексей Шилин wrote:
> reassign 881342 rtkit 0.11-4
> thanks
> 
> After a bit of investigation, I've found that the source of the issue is actually
> the rtkit package.
> 
> rtkit postinst script contains the following lines added by debhelper:
> 
>     # Automatically added by dh_systemd_start
>     if [ -d /run/systemd/system ]; then
>         systemctl --system daemon-reload >/dev/null || true
>         deb-systemd-invoke start rtkit-daemon.service >/dev/null || true
>     fi
>     # End automatically added section
> 
> Here rtkit-daemon service, which is of Type=dbus, is being started at package
> configuration phase.
> 
> systemd.service(5) says [1]:
> 
>     The following dependencies are implicitly added:
> 
>         * Services with Type=dbus set automatically acquire dependencies of type 
>           Requires= and After= on dbus.socket.
> 
> So starting rtkit-daemon.service activates dbus.socket which in turn leads to
> dbus.service activation when the rtkit daemon tries to connect to the bus.
> The issue here is that rtkit currently only recommends dbus, which doesn't
> guarantee proper ordering i.e. rtkit may be scheduled to be configured *before*
> dbus and thus start the latter before its configuration (which includes the system
> user creation) is complete, leading to the reported issue.

As I said on IRC, I can't think of any scenario where rtkit is useful
without dbus and polkit. Without dbus, rtkit won't start at all.
Withouut polkit, rtkit will start but will refuse to make any processes
realtime and is therefore a bit useless.

In my opinion, this bug is RC because rtkit needs to depend on these
packages to function. If someone can think of a way to use rtkit without
these packages then I may change my mind :)

> This issue should affect only stretch because according to its changelog rtkit is
> no longer started by default since 0.11-5. Whether the version in stable should
> be fixed is up to its maintainer. I've attached a patch which moves dbus from
> Recommends to Depends, fixing the issue.

While the installation issue only affects stretch, starting rtkit
manually without dbus installed is still broken in unstable so it should
also be fixed there.

Thanks,
James

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20180216/35a0ac1e/attachment.sig>