Bug#904052: ffmpeg: FTBFS on hurd-i386: wrong value for --target-os at configure

[Pino Toscano]

Source: ffmpeg
Version: 7:4.0-3
Severity: important
Tags: patch
User: debian-hurd at lists.debian.org
Usertags: hurd

Hi,

ffmpeg fails to build on hurd-i386 [1].

Since version 7:4.0-3 (commit d3d378eb963734f2d330754300a63eb440f2d676
in the packaging Git) --target-os is passed in all the cases to
configure, using $DEB_HOST_ARCH_OS as value.  The problem is that
configure expects for --target-os a (lowercase) value among the
possible ones returned by `uname -s`, which is "GNU" for Hurd.  OTOH,
$DEB_HOST_ARCH for hurd-* archs is "hurd", and thus configure fails
with "Unknown OS".

Attached there is a patch to use a custom variable for --target-os,
using the mapping needed (so far for hurd-* only).

[1] https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=hurd-i386&ver=7%3A4.0.1-2&stamp=1531923258&raw=0

Thanks,
-- 
Pino
-------------- next part --------------
--- a/debian/rules
+++ b/debian/rules
@@ -11,6 +11,13 @@ DEB_REVISION := $(word 2, $(subst -, ,$(
 # sets DEB_HOST_* variables
 include /usr/share/dpkg/architecture.mk
 
+# Set the right target OS
+ifeq ($(DEB_HOST_ARCH_OS),hurd)
+	TARGET_OS = gnu
+else
+	TARGET_OS = $(DEB_HOST_ARCH_OS)
+endif
+
 # Ubuntu ld adds -Bsymbolic-functions by default, but that prevents FFmpeg from building.
 export DEB_LDFLAGS_MAINT_STRIP=-Wl,-Bsymbolic-functions
 
@@ -46,7 +53,7 @@ CONFIG := --prefix=/usr \
 	--libdir=/usr/lib/$(DEB_HOST_MULTIARCH) \
 	--incdir=/usr/include/$(DEB_HOST_MULTIARCH) \
 	--arch=$(DEB_HOST_ARCH_CPU) \
-	--target-os=$(DEB_HOST_ARCH_OS) \
+	--target-os=$(TARGET_OS) \
 	--enable-gpl \
 	--disable-stripping \
 	--enable-avresample --disable-filter=resample \