Bug#904052: ffmpeg: FTBFS on hurd-i386: wrong value for --target-os at configure

[Pino Toscano]

In data sabato 21 luglio 2018 17:59:13 CEST, James Cowgill ha scritto:
> Hi,
> 
> On 18/07/18 22:18, Pino Toscano wrote:
> > Source: ffmpeg
> > Version: 7:4.0-3
> > Severity: important
> > Tags: patch
> > User: debian-hurd at lists.debian.org
> > Usertags: hurd
> > 
> > Hi,
> > 
> > ffmpeg fails to build on hurd-i386 [1].
> > 
> > Since version 7:4.0-3 (commit d3d378eb963734f2d330754300a63eb440f2d676
> > in the packaging Git) --target-os is passed in all the cases to
> > configure, using $DEB_HOST_ARCH_OS as value.  The problem is that
> > configure expects for --target-os a (lowercase) value among the
> > possible ones returned by `uname -s`, which is "GNU" for Hurd.  OTOH,
> > $DEB_HOST_ARCH for hurd-* archs is "hurd", and thus configure fails
> > with "Unknown OS".
> > 
> > Attached there is a patch to use a custom variable for --target-os,
> > using the mapping needed (so far for hurd-* only).
> 
> I think I'll just move the --target-os option back into the cross
> compilation block which will at least fix the native build. In the above
> commit it was only the --arch option which was important to always specify.

OK, thanks -- this solution LGTM.

> Maybe upstream FFmpeg could be taught to accept "hurd" as an alternate
> name for "gnu" in --target-os?

I'm not sure about this: since the default value is taken from the
output of $(uname -s), that returns "GNU" and not "hurd". I'd be like
adding eg "gnulinux" as alternate name for "linux", which IMHO does not
make sense.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-multimedia-maintainers/attachments/20180721/40e0fec1/attachment.sig>