Bug#897745: etl: ftbfs with GCC-8

[Philip Chung]

Control: tags -1 fixed-upstream

On Fri, 04 May 2018 12:21:30 +0000 Matthias Klose <doko at debian.org> wrote:
> Package: src:etl
> Version: 1.2.1-0.1
> Severity: normal
> Tags: sid buster
> User: debian-gcc at lists.debian.org
> Usertags: ftbfs-gcc-8
> 
> [...]
> 
> The package fails to build in a test rebuild on at least amd64 with
> gcc-8/g++-8, but succeeds to build with gcc-7/g++-7. The
> severity of this report will be raised before the buster release.
> 
> The full build log can be found at:
> http://aws-logs.debian.net/2018/05/01/gcc8/etl_1.2.1-0.1_unstable_gcc8.log.gz
> The last lines of the build log are at the end of this report.
> 

The error is here:

> In file included from ../ETL/pen:32,
>                  from pen.cpp:31:
> ../ETL/_pen.h: In member function 'etl::generic_pen<T, AT>::difference_type::value_type& etl::generic_pen<T, AT>::difference_type::operator[](int) const':
> ../ETL/_pen.h:139:51: error: binding reference of type 'etl::generic_pen<T, AT>::difference_type::value_type&' {aka 'int&'} to 'const value_type' {aka 'const int'} discards qualifiers
>    value_type &operator[](int i)const { return i?y:x; }
>                                                    ^
The error has been fixed upstream with this commit:
https://github.com/synfig/synfig/commit/cb05b072fe6fffb4433140c631f422bdbc036722

It adds overloads for operator[] for const-correctness.

Philip Chung