Bug#901577: vlc: Please add support for architecture "riscv64"

[Sebastian Ramacher]

Hi

On 2018-06-15 00:56:47, Manuel A. Fernandez Montecelo wrote:
> Source: src:vlc
> Version: 3.0.1-3
> Severity: normal
> Tags: patch upstream
> User: debian-riscv at lists.debian.org
> Usertags: riscv64
> 
> Hi,
> 
> vlc fails to build in riscv64:
> 
>   https://buildd.debian.org/status/fetch.php?pkg=vlc&arch=riscv64&ver=3.0.3-1&stamp=1527581471&raw=0
> 
> The reason for this failure is that it needs to be linked against -latomic to be
> able to work with sub-word sizes.  This library is pulled in automatically when
> using -pthread if needed, but presumably vlc uses -lpthread to link, which works
> in most places and architectures, but not this one.
> 
> I think that this happens in this block:
> 
>   https://sources.debian.org/src/vlc/3.0.3-1/configure.ac/?hl=806#L805
> 
> in which probably LIBPTHREAD="$ac_cv_search_pthread_rwlock_init" (or its use in
> later parts of the compilation) gets the value "-l + pthread" instead of the
> special "-pthread" needed in this case.
> 
> 
> I can build successfully just applying the attached minimal patch to
> debian/rules, which should also work fine for all arches, but maybe it would be
> better to apply only to riscv64.

… but does it acutally work?

> 
> It would probably be better to solve this upstream, I don't know if you
> can/prefer contact them or you prefer that we do it.  Also not sure how likely
> are they to fix the issue and how long it will take.

I think it would be better if you'd report the issue upstream at
https://trac.videolan.org/vlc/ so that it gets solved properly. For questions
about riscv64 I'd have to forward anything to you anyway.

> So we'll appreciate if you fix it in some way in Debian while it's not fixed
> upstream, otherwise a big part of the archive is blocked by this package, and we
> have to keep applying the patch, building the package and uploading to a special
> archive for this port with every upload or binNMU to src:vlc.

I can add the -pthread (for riscv64 only) in the next upload. But please,
please, please get it fixed upstream. I don't want to carry those kind of
workarounds around forever.

Cheers

> 
> 
> Thanks and cheers.
> --
> Manuel A. Fernandez Montecelo <mafm at debian.org>

> diff -Nru vlc-3.0.3/debian/changelog vlc-3.0.3/debian/changelog
> --- vlc-3.0.3/debian/changelog	2018-05-28 23:51:35.000000000 +0200
> +++ vlc-3.0.3/debian/changelog	2018-06-08 17:41:17.000000000 +0200
> @@ -1,3 +1,10 @@
> +vlc (3.0.3-1+0.riscv64.1) unreleased; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * riscv64: build with -pthread
> +
> + -- Manuel A. Fernandez Montecelo <mafm at debian.org>  Fri, 08 Jun 2018 15:41:17 +0000
> +
>  vlc (3.0.3-1) unstable; urgency=medium
>  
>    * New upstream release.
> diff -Nru vlc-3.0.3/debian/rules vlc-3.0.3/debian/rules
> --- vlc-3.0.3/debian/rules	2018-05-21 14:18:40.000000000 +0200
> +++ vlc-3.0.3/debian/rules	2018-06-08 17:41:17.000000000 +0200
> @@ -1,6 +1,6 @@
>  #!/usr/bin/make -f
>  
> -DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed
> +DEB_LDFLAGS_MAINT_APPEND=-Wl,--as-needed -pthread
>  DEB_BUILD_MAINT_OPTIONS=hardening=+all
>  
>  include /usr/share/dpkg/architecture.mk


-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-multimedia-maintainers/attachments/20180615/bb09abfd/attachment.sig>