Bug#882224: bs1770gain: enable dh-autoreconf

[Petter Reinholdtsen]

[James Cowgill]
> bs1770gain contains a build-dependency on dh-autoreconf, but since it
> uses compat 9 and does not enable it manually, it is never used. This
> looks like an oversight to me.

It is, but it is harder to fix than expected.  I tried to enable it by
raising the compat level from 9 to 10, but the build fail.

I used this change:

diff --git a/debian/compat b/debian/compat
index ec63514..f599e28 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-9
+10
diff --git a/debian/control b/debian/control
index 02d1b6c..b113e5d 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: sound
 Priority: optional
 Maintainer: Debian Multimedia Team <pkg-multimedia-maintainers at lists.alioth.debian.org>
 Uploaders: Petter Reinholdtsen <pere at debian.org>
-Build-depends: debhelper (>> 9)
+Build-depends: debhelper (>> 10~)
  , dh-autoreconf
  , libsox-dev
  , libavformat-dev (>= 7:2.7.0)

This is the failure I got:

   dh_autoreconf
automake: warnings are treated as errors
bs1770gain/Makefile.am:97: warning: call SOLIB,,avutil,$(FFSOX_AVUTIL_V: non-POSIX variable name
bs1770gain/Makefile.am:97: (probably a GNU make extension)
bs1770gain/Makefile.am:98: warning: call SOLIB,,swresample,$(FFSOX_SWRESAMPLE_V: non-POSIX variable name
bs1770gain/Makefile.am:98: (probably a GNU make extension)
bs1770gain/Makefile.am:99: warning: call SOLIB,,avcodec,$(FFSOX_AVCODEC_V: non-POSIX variable name
bs1770gain/Makefile.am:99: (probably a GNU make extension)
bs1770gain/Makefile.am:100: warning: call SOLIB,,avformat,$(FFSOX_AVFORMAT_V: non-POSIX variable name
bs1770gain/Makefile.am:100: (probably a GNU make extension)
bs1770gain/Makefile.am:101: warning: call SOLIB,lib,sox,$(FFSOX_LIBSOX_V: non-POSIX variable name
bs1770gain/Makefile.am:101: (probably a GNU make extension)
bs1770gain/Makefile.am:104: warning: call SOLIB,,avutil,$(FFSOX_AVUTIL_V: non-POSIX variable name
bs1770gain/Makefile.am:104: (probably a GNU make extension)
bs1770gain/Makefile.am:105: warning: call SOLIB,,swresample,$(FFSOX_SWRESAMPLE_V: non-POSIX variable name
bs1770gain/Makefile.am:105: (probably a GNU make extension)
bs1770gain/Makefile.am:106: warning: call SOLIB,,avcodec,$(FFSOX_AVCODEC_V: non-POSIX variable name
bs1770gain/Makefile.am:106: (probably a GNU make extension)
bs1770gain/Makefile.am:107: warning: call SOLIB,,avformat,$(FFSOX_AVFORMAT_V: non-POSIX variable name
bs1770gain/Makefile.am:107: (probably a GNU make extension)
bs1770gain/Makefile.am:108: warning: call SOLIB,lib,sox,$(FFSOX_LIBSOX_V: non-POSIX variable name
bs1770gain/Makefile.am:108: (probably a GNU make extension)
bs1770gain/Makefile.am:112: warning: call SOLIB,lib,sox,$(FFSOX_LIBSOX_V: non-POSIX variable name
bs1770gain/Makefile.am:112: (probably a GNU make extension)
bs1770gain/Makefile.am:113: warning: call SOLIB,,avformat,$(FFSOX_AVFORMAT_V: non-POSIX variable name
bs1770gain/Makefile.am:113: (probably a GNU make extension)
bs1770gain/Makefile.am:114: warning: call SOLIB,,avcodec,$(FFSOX_AVCODEC_V: non-POSIX variable name
bs1770gain/Makefile.am:114: (probably a GNU make extension)
bs1770gain/Makefile.am:115: warning: call SOLIB,,swresample,$(FFSOX_SWRESAMPLE_V: non-POSIX variable name
bs1770gain/Makefile.am:115: (probably a GNU make extension)
bs1770gain/Makefile.am:116: warning: call SOLIB,,avutil,$(FFSOX_AVUTIL_V: non-POSIX variable name
bs1770gain/Makefile.am:116: (probably a GNU make extension)
bs1770gain/Makefile.am:118: warning: '%'-style pattern rules are a GNU make extension
bs1770gain/Makefile.am:121: warning: '%'-style pattern rules are a GNU make extension
bs1770gain/Makefile.am:124: warning: '%'-style pattern rules are a GNU make extension
/usr/share/automake-1.15/am/library.am: warning: 'libbs1770gain.a': linking libraries using a non-POSIX
/usr/share/automake-1.15/am/library.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
bs1770gain/Makefile.am:65:   while processing library 'libbs1770gain.a'
bs1770gain/Makefile.am:1: warning: 'CFLAGS' is a user variable, you should not override it;
bs1770gain/Makefile.am:1: use 'AM_CFLAGS' instead
bs1770gain/Makefile.am:16: warning: 'CPPFLAGS' is a user variable, you should not override it;
bs1770gain/Makefile.am:16: use 'AM_CPPFLAGS' instead
bs1770gain/Makefile.am:25: warning: 'LDFLAGS' is a user variable, you should not override it;
bs1770gain/Makefile.am:25: use 'AM_LDFLAGS' instead
/usr/share/automake-1.15/am/library.am: warning: 'lib1770_2.a': linking libraries using a non-POSIX
/usr/share/automake-1.15/am/library.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
lib1770-2/Makefile.am:24:   while processing library 'lib1770_2.a'
lib1770-2/Makefile.am:1: warning: 'CFLAGS' is a user variable, you should not override it;
lib1770-2/Makefile.am:1: use 'AM_CFLAGS' instead
lib1770-2/Makefile.am:13: warning: 'CPPFLAGS' is a user variable, you should not override it;
lib1770-2/Makefile.am:13: use 'AM_CPPFLAGS' instead
/usr/share/automake-1.15/am/library.am: warning: 'libffsox_2.a': linking libraries using a non-POSIX
/usr/share/automake-1.15/am/library.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
libffsox-2/Makefile.am:27:   while processing library 'libffsox_2.a'
libffsox-2/Makefile.am:1: warning: 'CFLAGS' is a user variable, you should not override it;
libffsox-2/Makefile.am:1: use 'AM_CFLAGS' instead
libffsox-2/Makefile.am:14: warning: 'CPPFLAGS' is a user variable, you should not override it;
libffsox-2/Makefile.am:14: use 'AM_CPPFLAGS' instead
/usr/share/automake-1.15/am/library.am: warning: 'libpbutil.a': linking libraries using a non-POSIX
/usr/share/automake-1.15/am/library.am: archiver requires 'AM_PROG_AR' in 'configure.ac'
libpbutil/Makefile.am:20:   while processing library 'libpbutil.a'
libpbutil/Makefile.am:1: warning: 'CFLAGS' is a user variable, you should not override it;
libpbutil/Makefile.am:1: use 'AM_CFLAGS' instead
autoreconf: automake failed with exit status: 1
dh_autoreconf: autoreconf -f -i returned exit code 1
debian/rules:3: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

-- 
Happy hacking
Petter Reinholdtsen