Bug#908849: gerbera: No linefeed before CONNECTION header

[Pelzi]

Package: gerbera
Version: 1.1.0+dfsg-2+b2
Severity: normal

Dear Maintainer,

Try to play an audio track served by gerbera using the uPnP protocol. This leads to an ordinary http get from client (here VLC running on Mac OS).

As a result, Gerbera will send back an http answer, consisting of an HTTP header and content (which is intended to be streamed by the client). Gerbera 
adds "CONNECTION: close" to the last line of the header, whichever that is, e.g.: Accept-Ranges: bytesCONNECTION: close
(In certain situations the last header line might happen to be the Content-Disposition heder and in that case, VLC turns out to be
uncapable of parsing the header at all and will refuse to play the respective track.)

Instead, Gerbera should add another line to the header, i.e.
Accept-Ranges: bytes
CONNECTION: close
These lines must be separated by CR LF, as always in HTTP.


-- System Information:
Debian Release: buster/sid
 APT prefers testing
 APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.18.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gerbera depends on:
ii  adduser                  3.117
ii  libavformat58            7:4.0.2-1+b1
ii  libavutil56              7:4.0.2-1+b1
ii  libc6                    2.27-6
ii  libcurl3-gnutls          7.61.0-1
ii  libduktape203            2.3.0-1
ii  libexif12                0.6.21-5
ii  libexiv2-14              0.25-4
ii  libexpat1                2.2.6-1
ii  libffmpegthumbnailer4v5  2.1.1-0.2+b1
ii  libgcc1                  1:8.2.0-5
ii  libixml10                1:1.8.2-3
ii  libjs-bootstrap          3.3.7+dfsg-2
ii  libjs-jquery             3.2.1-1
ii  libjs-jquery-cookie      12-1
ii  libjs-jquery-ui          1.12.1+dfsg-5
ii  libjs-prototype          1.7.1-3
ii  libmagic1                1:5.34-2
ii  libmariadbclient18       1:10.1.35-1
ii  libsqlite3-0             3.24.0-1
ii  libstdc++6               8.2.0-5
ii  libtag1v5                1.11.1+dfsg.1-0.2+b1
ii  libupnp10                1:1.8.2-3
ii  libuuid1                 2.32.1-0.1
ii  lsb-base                 9.20170808
ii  zlib1g                   1:1.2.11.dfsg-1

gerbera recommends no packages.

Versions of packages gerbera suggests:
ii  firefox-esr [www-browser]  52.9.0esr-1
ii  konqueror [www-browser]    4:18.04.0-1
ii  lynx [www-browser]         2.8.9rel.1-2
ii  w3m [www-browser]          0.5.3-36+b1

-- Configuration Files:
/etc/gerbera/config.xml changed [not included]

-- no debconf information