Bug#931810: aeolus: segfault on startup

[Bernhard Übelacker]

Dear Maintainer,

> (On exit is another issue with the FILE structure
> in readline library, but saw it just on exit.)

I tried to follow why this crash on exit happens,
and found that this second issue is because aeolus
does a "fclose (stdin);" on purpose.

But libreadline is not prepared to that and raises this error.

Just removing that "fclose (stdin);" makes it
impossible to close aeolus.

Kind regards,
Bernhard



Aeolus> q
[Switching to Thread 0x7ffff6ea8700 (LWP 1514)]

Thread 8 "aeolus" hit Hardware watchpoint 1: rl_instream->_fileno

Old value = 0
New value = -1
_IO_new_file_close_it (fp=fp at entry=0x7ffff751da00 <_IO_2_1_stdin_>) at fileops.c:161
161     fileops.c: Datei oder Verzeichnis nicht gefunden.
(gdb) bt
#0  _IO_new_file_close_it (fp=fp at entry=0x7ffff751da00 <_IO_2_1_stdin_>) at fileops.c:161
#1  0x00007ffff73d190f in _IO_new_fclose (fp=0x7ffff751da00 <_IO_2_1_stdin_>) at iofclose.c:53
#2  0x00007ffff7fcb642 in Tiface::handle_ifc_txtip (this=0x55555563d7a0, M=<optimized out>) at tiface.cc:248
#3  0x00007ffff7fcb728 in Tiface::handle_mesg (this=<optimized out>, M=0x7fffdc09f610) at tiface.cc:163
#4  0x00007ffff7fcb7aa in Tiface::thr_main (this=0x55555563d7a0) at /usr/include/clthreads.h:492
#5  0x00007ffff7bb6a3a in P_thread_entry_point (arg=<optimized out>) at p_thread.cc:38
#6  0x00007ffff7852fa3 in start_thread (arg=<optimized out>) at pthread_create.c:486
#7  0x00007ffff745b4cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
(gdb) cont
Continuing.
Aeolus> *** buffer overflow detected ***: /usr/bin/aeolus terminated

Thread 9 "aeolus" received signal SIGABRT, Aborted.
[Switching to Thread 0x7ffff6e58700 (LWP 1515)]
__GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50        return ret;
(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ffff7384535 in __GI_abort () at abort.c:79
#2  0x00007ffff73db508 in __libc_message (action=<optimized out>, fmt=fmt at entry=0x7ffff74e607b "*** %s ***: %s terminated\n") at ../sysdeps/posix/libc_fatal.c:181
#3  0x00007ffff746c80d in __GI___fortify_fail_abort (need_backtrace=need_backtrace at entry=true, msg=msg at entry=0x7ffff74e5ff8 "buffer overflow detected") at fortify_fail.c:28
#4  0x00007ffff746c841 in __GI___fortify_fail (msg=msg at entry=0x7ffff74e5ff8 "buffer overflow detected") at fortify_fail.c:44
#5  0x00007ffff746a940 in __GI___chk_fail () at chk_fail.c:28
#6  0x00007ffff746c737 in __fdelt_chk (d=<optimized out>) at fdelt_chk.c:25
#7  0x00007ffff70cdd67 in rl_getc (stream=0x7ffff751da00 <_IO_2_1_stdin_>) at ./input.c:518
#8  0x00007ffff70ce61e in rl_read_key () at ./input.c:483
#9  0x00007ffff70b64f5 in readline_internal_char () at ./readline.c:570
#10 0x00007ffff70b6cd5 in readline_internal_charloop () at ./readline.c:656
#11 readline_internal () at ./readline.c:670
#12 readline (prompt=prompt at entry=0x7ffff7fcc01e "Aeolus> ") at ./readline.c:376
#13 0x00007ffff7fc95ac in Reader::thr_main (this=0x55555563db98) at tiface.cc:64
#14 0x00007ffff7bb6a3a in P_thread_entry_point (arg=<optimized out>) at p_thread.cc:38
#15 0x00007ffff7852fa3 in start_thread (arg=<optimized out>) at pthread_create.c:486
#16 0x00007ffff745b4cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95