Bug#944635: jack-tools FTCBFS: hard codes the build architecture compiler

Helmut Grohne helmut at subdivi.de
Wed Nov 13 05:18:21 GMT 2019


Source: jack-tools
Version: 20131226-1
Tags: patch
User: debian-cross at lists.debian.org
Usertags: ftcbfs

jack-tools fails to cross build from source, because the upstream
Makefile hard codes the build architecture compiler. The attached patch
makes it substitutable and additionally makes debian/rules export cross
tools using dpkg's buildtools.mk to make jack-tools cross buildable.
Please consider applying the attached patch.

Helmut
-------------- next part --------------
diff --minimal -Nru jack-tools-20131226/debian/changelog jack-tools-20131226/debian/changelog
--- jack-tools-20131226/debian/changelog	2014-10-15 15:54:35.000000000 +0200
+++ jack-tools-20131226/debian/changelog	2019-11-13 06:02:12.000000000 +0100
@@ -1,3 +1,12 @@
+jack-tools (20131226-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + cross.patch: Make the compiler substitutable.
+    + Let dpkg's buildtools.mk supply cross tools.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Wed, 13 Nov 2019 06:02:12 +0100
+
 jack-tools (20131226-1) unstable; urgency=medium
 
   * Team upload.
diff --minimal -Nru jack-tools-20131226/debian/patches/cross.patch jack-tools-20131226/debian/patches/cross.patch
--- jack-tools-20131226/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ jack-tools-20131226/debian/patches/cross.patch	2019-11-13 06:02:09.000000000 +0100
@@ -0,0 +1,38 @@
+--- jack-tools-20131226.orig/Makefile
++++ jack-tools-20131226/Makefile
+@@ -8,19 +8,19 @@
+ all: $(bin)
+ 
+ jack-transport: jack-transport.c
+-	gcc $(CFLAGS) $(LDFLAGS) -o jack-transport jack-transport.c $(LDLIBS) -lcurses
++	$(CC) $(CFLAGS) $(LDFLAGS) -o jack-transport jack-transport.c $(LDLIBS) -lcurses
+ 
+ jack-dl: jack-dl.c
+-	gcc $(CFLAGS) $(LDFLAGS) -o jack-dl jack-dl.c $(LDLIBS) -ldl -llo
++	$(CC) $(CFLAGS) $(LDFLAGS) -o jack-dl jack-dl.c $(LDLIBS) -ldl -llo
+ 
+ jack-play: jack-play.c
+-	gcc $(CFLAGS) $(LDFLAGS) -o jack-play jack-play.c $(LDLIBS) -lsndfile -lsamplerate
++	$(CC) $(CFLAGS) $(LDFLAGS) -o jack-play jack-play.c $(LDLIBS) -lsndfile -lsamplerate
+ 
+ jack-record: jack-record.c
+-	gcc $(CFLAGS) $(LDFLAGS) -o jack-record jack-record.c $(LDLIBS) -lsndfile
++	$(CC) $(CFLAGS) $(LDFLAGS) -o jack-record jack-record.c $(LDLIBS) -lsndfile
+ 
+ jack-scope: jack-scope.c
+-	gcc $(CFLAGS) $(LDFLAGS) -o jack-scope jack-scope.c $(LDLIBS) -lX11 -lXext
++	$(CC) $(CFLAGS) $(LDFLAGS) -o jack-scope jack-scope.c $(LDLIBS) -lX11 -lXext
+ 
+ clean:
+ 	(cd c-common ; make clean)
+--- jack-tools-20131226.orig/c-common/Makefile
++++ jack-tools-20131226/c-common/Makefile
+@@ -47,7 +47,7 @@
+ 	xregcomp.o
+ 
+ %.o : %.c %.h
+-	gcc -Wall -O2 -c $*.c
++	$(CC) -Wall -O2 -c $*.c
+ 
+ all: $(obj)
+ 	ar -rcs lib-c-common.a $(obj)
diff --minimal -Nru jack-tools-20131226/debian/patches/series jack-tools-20131226/debian/patches/series
--- jack-tools-20131226/debian/patches/series	2014-10-15 14:58:14.000000000 +0200
+++ jack-tools-20131226/debian/patches/series	2019-11-13 06:01:36.000000000 +0100
@@ -2,3 +2,4 @@
 make-installation-directories.patch
 use_ldflags.patch
 jackplay_flags.patch
+cross.patch
diff --minimal -Nru jack-tools-20131226/debian/rules jack-tools-20131226/debian/rules
--- jack-tools-20131226/debian/rules	2014-10-15 14:58:14.000000000 +0200
+++ jack-tools-20131226/debian/rules	2019-11-13 06:02:12.000000000 +0100
@@ -17,6 +17,8 @@
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+DPKG_EXPORT_BUILDTOOLS = 1
+include /usr/share/dpkg/buildtools.mk
 include /usr/share/cdbs/1/rules/debhelper.mk
 include /usr/share/cdbs/1/rules/utils.mk
 include /usr/share/cdbs/1/class/makefile.mk


More information about the pkg-multimedia-maintainers mailing list