Bug#957055: bristol: ftbfs with GCC-10

[Matthias Klose]

Package: src:bristol
Version: 0.60.11-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/bristol_0.60.11-3_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brightonCLI.c: In function ‘execAlias’:
brightonCLI.c:1190:37: warning: ‘%12s’ directive output may be truncated writing between 12 and 23327 bytes into a region of size 256 [-Wformat-truncation=]
 1190 |     snprintf(pbuf, B_TTY_LINE_LEN, "%12s: %s\n\r",
      |                                     ^~~~
In file included from /usr/include/stdio.h:867,
                 from brightonCLI.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output 17 or more bytes (assuming 23332) into a destination of size 256
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brightonCLI.c: In function ‘brightonGetCLIcodes’:
brightonCLI.c:682:45: warning: ‘%s’ directive output may be truncated writing up to 23327 bytes into a region of size 241 [-Wformat-truncation=]
  682 |    snprintf(pbuf, btty.len, "CLI: set alias %s %s\n",
      |                                             ^~
In file included from /usr/include/stdio.h:867,
                 from brightonCLI.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output 18 or more bytes (assuming 23345) into a destination of size 256
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brightonCLI.c: In function ‘execCLI’:
brightonCLI.c:1147:35: warning: ‘%s’ directive output may be truncated writing up to 1295 bytes into a region of size 252 [-Wformat-truncation=]
 1147 |     snprintf(pbuf, btty.len, "    %s\n\r", templates[i].opname);
      |                                   ^~
In file included from /usr/include/stdio.h:867,
                 from brightonCLI.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 7 and 1302 bytes into a destination of size 256
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brightonCLI.c: In function ‘bttyCookedMode’:
brightonCLI.c:3564:33: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 254 [-Wformat-truncation=]
 3564 |    snprintf(pbuf, btty.len, "\r/%s", cbuf);
      |                                 ^~   ~~~~
In file included from /usr/include/stdio.h:867,
                 from brightonCLI.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 3 and 258 bytes into a destination of size 256
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
brightonCLI.c:3562:34: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size between 192 and 255 [-Wformat-truncation=]
 3562 |    snprintf(pbuf, btty.len, "\r%s%s", btty.prompt, cbuf);
      |                                  ^~                ~~~~
In file included from /usr/include/stdio.h:867,
                 from brightonCLI.c:31:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: note: ‘__builtin___snprintf_chk’ output between 2 and 320 bytes into a destination of size 256
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/bin/bash ../libtool  --tag=CC   --mode=link gcc -pthread -Wall -g -I./../include/brighton -I./../include/bristol -DBRISTOL_HAS_ALSA=1 -DBRIGHTON_HAS_X11 -DBRISTOL_VOICECOUNT=32 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/X11R6/include -Bdynamic -L../libbrighton/ -L../libbristolmidi/.libs -L../libbrightonX11 -L/usr/X11R6/lib -L../libbvg -Wl,-z,relro -o brighton brightonArp2600.o brightonAxxe.o brighton.o brightonControllers.o brightonDX.o brightonExplorer.o brightonHammondB3.o brightonHammond.o brightonJuno.o brightonMemoryMoog.o brightonMini.o brightonMixer.o brightonMixerMemory.o brightonMixerMenu.o brightonMS20.o brightonOBXa.o brightonOBX.o brightonOdyssey.o brightonPoly6.o brightonPoly.o brightonProphet10.o brightonProphet52.o brightonProphet.o brightonRhodesBass.o brightonRhodes.o brightonRoutines.o brightonSAks.o brightonVox.o brightonSolina.o brightonRoadRunner.o brightonGranular.o brightonRealistic.o brightonVoxM2.o brightonJupiter.o brightonBitOne.o brightonMaster.o brightonCS80.o brightonProOne.o brightonVoyager.o brightonSonic6.o brightonTrilogy.o brightonStratus.o brightonPoly800.o brightonBME700.o brightonBassMaker.o brightonSID.o brightonSID2.o brightonCLI.o -lbrighton -lbvg -lB11 -lX11  -lbristolmidi -lasound -lm -lpthread 
libtool: link: gcc -pthread -Wall -g -I./../include/brighton -I./../include/bristol -DBRISTOL_HAS_ALSA=1 -DBRIGHTON_HAS_X11 -DBRISTOL_VOICECOUNT=32 -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -I/usr/X11R6/include -Bdynamic -Wl,-z -Wl,relro -o .libs/brighton brightonArp2600.o brightonAxxe.o brighton.o brightonControllers.o brightonDX.o brightonExplorer.o brightonHammondB3.o brightonHammond.o brightonJuno.o brightonMemoryMoog.o brightonMini.o brightonMixer.o brightonMixerMemory.o brightonMixerMenu.o brightonMS20.o brightonOBXa.o brightonOBX.o brightonOdyssey.o brightonPoly6.o brightonPoly.o brightonProphet10.o brightonProphet52.o brightonProphet.o brightonRhodesBass.o brightonRhodes.o brightonRoutines.o brightonSAks.o brightonVox.o brightonSolina.o brightonRoadRunner.o brightonGranular.o brightonRealistic.o brightonVoxM2.o brightonJupiter.o brightonBitOne.o brightonMaster.o brightonCS80.o brightonProOne.o brightonVoyager.o brightonSonic6.o brightonTrilogy.o brightonStratus.o brightonPoly800.o brightonBME700.o brightonBassMaker.o brightonSID.o brightonSID2.o brightonCLI.o  -L../libbrighton/ -L../libbristolmidi/.libs -L../libbrightonX11 -L/usr/X11R6/lib -L../libbvg -lbrighton -lbvg -lB11 -lX11 /<<PKGBUILDDIR>>/libbristolmidi/.libs/libbristolmidi.so -lasound -lm -lpthread -pthread -Wl,-rpath -Wl,/usr/lib/bristol
/usr/bin/ld: brightonCLI.o:./brighton/brightonCLI.c:139: multiple definition of `event'; brightonMixerMenu.o:./brighton/brightonMixerMenu.c:1182: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:482: brighton] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/brighton'
make[2]: *** [Makefile:443: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:375: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:14: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2