Bug#957407: klystrack: ftbfs with GCC-10

[Matthias Klose]

Package: src:klystrack
Version: 0.20171212-4
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/klystrack_0.20171212-4_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
   57 |  snprintf(new_filename, sizeof(new_filename), "%s.%04d%02d%02d-%02d%02d%02d.backup", filename,
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   58 |   now_tm->tm_year + 1900, now_tm->tm_mon + 1, now_tm->tm_mday, now_tm->tm_hour, now_tm->tm_min, now_tm->tm_sec);
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/diskop.c:834:4: warning: ‘strncpy’ output may be truncated copying 999 bytes from a string of length 4999 [-Wstringop-truncation]
  834 |    strncpy(mused.previous_song_filename, filename, sizeof(mused.previous_song_filename) - 1);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling xm.c...
Compiling ahx.c...
src/import/ahx.c: In function ‘import_ahx’:
src/import/ahx.c:543:2: warning: ‘strncpy’ specified bound 65 equals destination size [-Wstringop-truncation]
  543 |  strncpy(mused.song.title, ptr, sizeof(mused.song.title));
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/import/ahx.c:543:2: warning: ‘strncpy’ specified bound 65 equals destination size [-Wstringop-truncation]
Compiling mod.c...
Compiling import.c...
Compiling hubdialog.c...
Compiling hubbard.c...
Compiling org.c...
Compiling visu.c...
Compiling wavetableview.c...
Compiling pattern.c...
Compiling sequence.c...
Compiling timer.c...
Linking klystrack...
/usr/bin/ld: objs.release/view.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/config.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/key.o:(.bss+0x1040): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/menudefs.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/copypaste.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/zap.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/optimize.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/console.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/help.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/theme.o:(.bss+0x1100): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/wave_action.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/edit.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/shortcutdefs.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/main.o:(.bss+0xaae0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/export.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/event.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/stats.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/undo.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/mused.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/command.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/action.o:(.bss+0x20): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/diskop.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_xm.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_ahx.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_mod.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_import.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_hubdialog.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_hubbard.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/import_org.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/view_visu.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/view_wavetableview.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/view_pattern.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/view_sequence.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: objs.release/view_timer.o:(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
/usr/bin/ld: ../klystron/bin.release/libengine_gui.a(gui_menu.o):(.bss+0x0): multiple definition of `menu_t'; objs.release/clipboard.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:213: bin.release/klystrack] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/klystrack'
make[2]: *** [Makefile:137: build] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/klystrack'
dh_auto_build: error: cd klystrack && make -j4 "INSTALL=install --strip-program=true" CFG=release returned exit code 2
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:12: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2