Bug#957769: rotter: ftbfs with GCC-10

[Matthias Klose]

Package: src:rotter
Version: 0.9-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/rotter_0.9-3_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
checking termios.h presence... yes
checking for termios.h... yes
checking for usleep... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating src/config.h
config.status: executing depfiles commands
configure: WARNING: unrecognized options: --disable-silent-rules, --disable-maintainer-mode

Building rotter version 0.9.

         TwoLAME codec (MP2): No 
            LAME codec (MP3): Yes 
                  libsndfile: Yes 

Next type 'make' to begin compilation.
   dh_auto_build
dh_auto_build: warning: Compatibility levels before 9 are deprecated (level 7 in use)
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
Making all in src
make[2]: Entering directory '/<<PKGBUILDDIR>>/src'
make  all-am
make[3]: Entering directory '/<<PKGBUILDDIR>>/src'
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c rotter.c
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c jack.c
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c twolame.c
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c sndfile.c
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c lame.c
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c mpegaudiofile.c
mpegaudiofile.c: In function ‘close_mpegaudio_file’:
mpegaudiofile.c:136:60: warning: ‘%2.2d’ directive output may be truncated writing between 2 and 11 bytes into a region of size between 8 and 15 [-Wformat-truncation=]
  136 |  snprintf( id3.title, sizeof(id3.title)-1, "Recorded %4.4d-%2.2d-%2.2d %2.2d:%2.2d",
      |                                                            ^~~~~
mpegaudiofile.c:136:44: note: directive argument in the range [-2147483647, 2147483647]
  136 |  snprintf( id3.title, sizeof(id3.title)-1, "Recorded %4.4d-%2.2d-%2.2d %2.2d:%2.2d",
      |                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mpegaudiofile.c:136:2: note: ‘snprintf’ output between 26 and 69 bytes into a destination of size 29
  136 |  snprintf( id3.title, sizeof(id3.title)-1, "Recorded %4.4d-%2.2d-%2.2d %2.2d:%2.2d",
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  137 |     tm.tm_year+1900, tm.tm_mon+1, tm.tm_mday, tm.tm_hour, tm.tm_min );
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mpegaudiofile.c:150:18: warning: ‘%4.4d’ directive writing between 4 and 11 bytes into a region of size 5 [-Wformat-overflow=]
  150 |  sprintf( year, "%4.4d" , tm.tm_year+1900);
      |                  ^~~~~
mpegaudiofile.c:150:17: note: directive argument in the range [-2147481748, 2147483647]
  150 |  sprintf( year, "%4.4d" , tm.tm_year+1900);
      |                 ^~~~~~~
mpegaudiofile.c:150:2: note: ‘sprintf’ output between 5 and 12 bytes into a destination of size 5
  150 |  sprintf( year, "%4.4d" , tm.tm_year+1900);
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
gcc -DHAVE_CONFIG_H -I.     -g -O2 -Wunused -Wall     -c deletefiles.c
gcc  -g -O2 -Wunused -Wall       -o rotter rotter.o jack.o twolame.o sndfile.o lame.o mpegaudiofile.o deletefiles.o  -lm -lm  -ljack -lpthread  -lmp3lame -lsndfile
/usr/bin/ld: jack.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
/usr/bin/ld: twolame.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
/usr/bin/ld: sndfile.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
/usr/bin/ld: lame.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
/usr/bin/ld: mpegaudiofile.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
/usr/bin/ld: deletefiles.o:/<<PKGBUILDDIR>>/src/rotter.h:135: multiple definition of `mpegaudio_file'; rotter.o:/<<PKGBUILDDIR>>/src/rotter.h:135: first defined here
collect2: error: ld returned 1 exit status
make[3]: *** [Makefile:279: rotter] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:189: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:325: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:4: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2