Bug#964659: sonic-pi: FTBFS: sonicpiscintilla.cpp:188:48: error: ‘QString& QString::sprintf(const char*, ...) ’ is deprecated: Use asprintf(), arg() or QTextStream instead [-Werror=deprecated-declarations]

[Lucas Nussbaum]

Source: sonic-pi
Version: 2.10.0~repack-2.1
Severity: serious
Justification: FTBFS on amd64
Tags: bullseye sid ftbfs
Usertags: ftbfs-20200709 ftbfs-bullseye

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

Relevant part (hopefully):
> g++ -c -pipe -Wall -Werror -Wextra -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra -D_REENTRANT -fPIC -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CONCURRENT_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I/Users/sam/Downloads/tmp/QScintilla-gpl-2.9/Qt4Qt5 -isystem /usr/include/x86_64-linux-gnu/qt5 -isystem /usr/include/x86_64-linux-gnu/qt5/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt5/QtGui -isystem /usr/include/x86_64-linux-gnu/qt5/QtConcurrent -isystem /usr/include/x86_64-linux-gnu/qt5/QtNetwork -isystem /usr/include/x86_64-linux-gnu/qt5/QtCore -I. -I/usr/lib/x86_64-linux-gnu/qt5/mkspecs/linux-g++ -o sonicpilog.o sonicpilog.cpp
> sonicpiscintilla.cpp: In member function ‘void SonicPiScintilla::addOtherKeyBinding(QSettings&, int, int)’:
> sonicpiscintilla.cpp:188:48: error: ‘QString& QString::sprintf(const char*, ...)’ is deprecated: Use asprintf(), arg() or QTextStream instead [-Werror=deprecated-declarations]
>   188 |   skey.sprintf("/Scintilla/keymap/c%d/alt", cmd);
>       |                                                ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:46,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QUrl:1,
>                  from /usr/include/x86_64-linux-gnu/qt5/Qsci/qsciscintilla.h:25,
>                  from sonicpiscintilla.h:14,
>                  from sonicpiscintilla.cpp:14:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:382:14: note: declared here
>   382 |     QString &sprintf(const char *format, ...) Q_ATTRIBUTE_FORMAT_PRINTF(2, 3);
>       |              ^~~~~~~
> sonicpiscintilla.cpp: In member function ‘void SonicPiScintilla::addKeyBinding(QSettings&, int, int)’:
> sonicpiscintilla.cpp:195:48: error: ‘QString& QString::sprintf(const char*, ...)’ is deprecated: Use asprintf(), arg() or QTextStream instead [-Werror=deprecated-declarations]
>   195 |   skey.sprintf("/Scintilla/keymap/c%d/key", cmd);
>       |                                                ^
> In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qurl.h:46,
>                  from /usr/include/x86_64-linux-gnu/qt5/QtCore/QUrl:1,
>                  from /usr/include/x86_64-linux-gnu/qt5/Qsci/qsciscintilla.h:25,
>                  from sonicpiscintilla.h:14,
>                  from sonicpiscintilla.cpp:14:
> /usr/include/x86_64-linux-gnu/qt5/QtCore/qstring.h:382:14: note: declared here
>   382 |     QString &sprintf(const char *format, ...) Q_ATTRIBUTE_FORMAT_PRINTF(2, 3);
>       |              ^~~~~~~
> cc1plus: all warnings being treated as errors
> make[1]: *** [Makefile:1265: sonicpiscintilla.o] Error 1

The full build log is available from:
   http://qa-logs.debian.net/2020/07/09/sonic-pi_2.10.0~repack-2.1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.