Bug#980023: petri-foo: FTBFS with GCC 10

[Logan Rosen]

Source: petri-foo
Version: 0.1.87-4
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source (but built successfully in the past)
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu hirsute ubuntu-patch
X-Debbugs-Cc: logan at ubuntu.com

Hi,

petri-foo currently FTBFS on rebuild in unstable with GCC 10 as default
because of a variable being defined multiple times.

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/gcc-10.patch: Fix FTBFS with GCC 10.

Thanks for considering the patch.

Logan
-------------- next part --------------
diff -Nru petri-foo-0.1.87/debian/control petri-foo-0.1.87/debian/control
--- petri-foo-0.1.87/debian/control	2018-02-05 11:51:44.000000000 -0500
+++ petri-foo-0.1.87/debian/control	2021-01-12 22:37:28.000000000 -0500
@@ -1,8 +1,7 @@
 Source: petri-foo
 Section: sound
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers at lists.alioth.debian.org>
+Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers at lists.alioth.debian.org>
 Uploaders:
  Alessio Treglia <alessio at debian.org>,
  Jaromír Mikeš <mira.mikes at seznam.cz>
diff -Nru petri-foo-0.1.87/debian/patches/gcc-10.patch petri-foo-0.1.87/debian/patches/gcc-10.patch
--- petri-foo-0.1.87/debian/patches/gcc-10.patch	1969-12-31 19:00:00.000000000 -0500
+++ petri-foo-0.1.87/debian/patches/gcc-10.patch	2021-01-12 22:37:27.000000000 -0500
@@ -0,0 +1,21 @@
+--- a/gui/gui.c
++++ b/gui/gui.c
+@@ -93,6 +93,8 @@
+ /* current patch, makes passing patch id to sample editor easier */
+ static int cur_patch = -1;
+ 
++GtkRecentManager *recent_manager;
++
+ 
+ GtkWidget* gui_title_new(const char* msg)
+ {
+--- a/gui/gui.h
++++ b/gui/gui.h
+@@ -107,6 +107,6 @@
+ 
+ void gui_set_session_mode(void);
+ 
+-GtkRecentManager *recent_manager;
++extern GtkRecentManager *recent_manager;
+  
+ #endif /* __GUI_H__ */
diff -Nru petri-foo-0.1.87/debian/patches/series petri-foo-0.1.87/debian/patches/series
--- petri-foo-0.1.87/debian/patches/series	2016-12-23 10:09:46.000000000 -0500
+++ petri-foo-0.1.87/debian/patches/series	2021-01-12 22:36:12.000000000 -0500
@@ -1,2 +1,3 @@
 0003-desktop_file_fix.patch
 0005-spelling.patch
+gcc-10.patch