Fwd: Borg-ER 3 Software Tone Synthesizer

[James Fletcher]

Hey I have made the changes you noted at this new repository; 
https://github.com/BeverlyCode/Borg-ER-3

Is this better?

- I have a better makefile!
- I have picked a new icon, and in the res.h file it defines the 
ownership/license of the assets.
- LICENSE is updated to "Copyright (c) 2021 James William Fletcher" 
rather than VOXDSP (my old company front).
- I have added a release; 
https://github.com/BeverlyCode/Borg-ER-3/releases/tag/1.0
- All binary or compilation artifacts have been removed from the source 
code repository.

I've recently released this on Flathub so there is a freedesktop xml at; 
https://github.com/BeverlyCode/Borg-ER-3/blob/main/flatpak/borg.appdata.xml 
with a desktop icon.

Is this better? Is there anything else that I need to do?

Thank you!

James

On 15/01/2023 20:16, IOhannes m zmölnig (Debian/GNU) wrote:
> On 1/14/23 17:19, James Fletcher wrote:
>> Hi all,
>>
>> The software I would like to add to Debian media list is my software 
>> tone synthesizer which is my most popular release on Snapcraft 
>> currently with 260+ installs.
>>
>> https://github.com/mrbid/Borg ER-3
>>
>> there is also the simpler Borg ER-0: https://github.com/mrbid/Borg-ER-0
>
> thanks for your interest in supporting Debian.
>
> i had a quick look at your repositories, and here's just a few 
> suggestions:
> - your makefile seems to be... unconventional (mostly: hardcoding 
> 'gcc' as the compiler; and *install*ing to some directory where nobody 
> would expect a binary to end up)
> - it seems like ths sources for the images encoded in res.h are missing
> - i cannot relate the LICENSE to you.
> - there are no releases. (or tags.)
>   Debian is more or less centered around proper upstream releases.
> - your git repository contains files like SDL2.dll, borg.exe, 
> borg.AppImage and borg.deb
>   you are of course free to put whatever you want into your 
> repository, but at least for me build artifacts (binaries!) in the 
> repository are a serious reason to not look much deeper. (otoh, if 
> there were releases, i wouldn't even (need to) look at the repository; 
> but if the releases consisted of "source tarballs" where 1/3 of the 
> files were just binary artifacts created from the remaining files, i 
> would again lose interest)
>
> if you are interested, you might want to check
>  https://wiki.debian.org/UpstreamGuide
>
> mfdsr
> IOhannes