<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 14, 2016 at 9:44 PM, Adrian Knoth <span dir="ltr"><<a href="mailto:adi@drcomp.erfurt.thur.de" target="_blank">adi@drcomp.erfurt.thur.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Fri, Nov 04, 2016 at 10:12:32AM +0100, Michael Stapelberg wrote:<br>
<br>
Hi!<br>
<br>
> > <a href="https://anonscm.debian.org/gitweb/?p=pkg-multimedia/qstopmotion.git" rel="noreferrer" target="_blank">https://anonscm.debian.org/<wbr>gitweb/?p=pkg-multimedia/<wbr>qstopmotion.git</a><br>
<span class="gmail-">><br>
> I have a couple of comments which I’d like to see addressed before I can<br>
> upload the package :)<br>
><br>
</span>> - Can you make the package largely lintian clean please? My config is at<br>
<br>
Done.<br></blockquote><div><br></div><div>I’ll note for completeness that I’m still seeing these two lintian warnings:</div><div><br></div><div>I: qstopmotion: arch-dep-package-has-big-usr-share 7090kB 83%<br></div><div><div>I: qstopmotion: possible-documentation-but-no-doc-base-registration</div></div><div><br></div><div>I’m not entirely sure about the former. The files which take up most of the space in /usr/share live in /usr/share/qstopmotion/translations. Is it customary for Qt apps to ship their translations in that path? If so, I suppose we can ignore the warning for now.</div><div><br></div><div>Please fix the latter warning about the missing doc-base, though.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
> and debian-watch-may-check-gpg-<wbr>signature might not be feasible. But can<br>
> hardening be turned on?<br>
<br>
</span>I think hardening defaults to on as of dh-compat 9, at least in<br>
conjunction with cmake. I do see the corresponding compiler flags set.<br></blockquote><div><br></div><div>It does, but not all flags. Notably, bindnow isn’t enabled by default (but triggers a lintian warning). Can you test+apply the following change please?</div><div><br></div><div><div><font face="monospace, monospace">@@ -3,7 +3,7 @@</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> # see FEATURE AREAS in dpkg-buildflags(1)</font></div><div><font face="monospace, monospace">-#export DEB_BUILD_MAINT_OPTIONS = hardening=+all</font></div><div><font face="monospace, monospace">+export DEB_BUILD_MAINT_OPTIONS = hardening=+all</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> # see ENVIRONMENT in dpkg-buildflags(1)</font></div><div><font face="monospace, monospace"> # package maintainers to append CFLAGS</font></div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> - Is it common in pkg-multimedia to not use pristine-tar? If there’s no<br>
<br>
Nope, was an oversight. Fixed.<br>
<br>
> - Given that it takes multiple minutes to compile, can the package be<br>
> built with --parallel?<br>
<br>
It can. At least it will if DEB_BUILD_OPTIONS is set to parallel=X. Do<br>
you suggest to set it explicitly in debian/rules? Or do the buildds set<br>
it automatically?<br></blockquote><div><br></div><div>Package as-is:</div><div><div><font face="monospace, monospace">DEB_BUILD_OPTIONS='parallel=8' gbp buildpackage 173,88s user 17,99s system 93% cpu 3:26,07 total</font></div></div><div><br></div><div>When adding --parallel to the dh call in debian/rules:</div><div><div><font face="monospace, monospace">DEB_BUILD_OPTIONS='parallel=8' gbp buildpackage 167,98s user 15,37s system 224% cpu 1:21,81 total</font></div></div><div><br></div><div>So, please make the following change:</div><div><div><font face="monospace, monospace">@@ -13,7 +13,7 @@</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> %:</font></div><div><font face="monospace, monospace">- dh $@ --buildsystem=cmake</font></div><div><font face="monospace, monospace">+ dh $@ --buildsystem=cmake --parallel</font></div><div><font face="monospace, monospace"> </font></div><div><font face="monospace, monospace"> </font></div></div><div><br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> - Can you forward cmake-gphoto2.patch to upstream please?<br>
> - Could you bump debian/compat to 10 please?<br>
<br>
All done.<br>
<br>
I had a mistake in the initial import (debian.patch in upstream branch),<br>
which is why I had to re-set the corresponding branch (read: I re-wrote<br>
history - bad, I know, but fortunately no other users, yet).<br>
<br>
In other words: git pull won't work, better start over with git clone.<br>
<br>
<br>
Cheers<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
--<br>
mail: <a href="mailto:adi@thur.de">adi@thur.de</a> <a href="http://adi.thur.de" rel="noreferrer" target="_blank">http://adi.thur.de</a> PGP/GPG: key via keyserver<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>